Skip to content

Commit e56be6c

Browse files
committed
Use test uid from record
1 parent 9931e96 commit e56be6c

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

openhtf/core/test_record.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ class TestRecord(object):
186186
diagnoses = attr.ib(type=List['diagnoses_lib.Diagnosis'], factory=list)
187187
log_records = attr.ib(type=List[logs.LogRecord], factory=list)
188188
marginal = attr.ib(type=Optional[bool], default=None)
189+
test_uid = attr.ib(type=Optional[Text], default=None)
189190

190191
# Cache fields to reduce repeated base type conversions.
191192
_cached_record = attr.ib(type=Dict[Text, Any], factory=dict)
@@ -266,6 +267,7 @@ def as_base_types(self) -> Dict[Text, Any]:
266267
'diagnosers': self._cached_diagnosers,
267268
'diagnoses': self._cached_diagnoses,
268269
'log_records': self._cached_log_records,
270+
'test_uid': self.test_uid,
269271
}
270272
ret.update(self._cached_record)
271273
return ret

openhtf/core/test_state.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,8 @@ def __init__(self, test_desc: 'test_descriptor.TestDescriptor',
148148
start_time_millis=0,
149149
# Copy metadata so we don't modify test_desc.
150150
metadata=copy.deepcopy(test_desc.metadata),
151-
diagnosers=test_options.diagnosers)
151+
diagnosers=test_options.diagnosers,
152+
test_uid=execution_uid)
152153
logs.initialize_record_handler(execution_uid, self.test_record,
153154
self.notify_update)
154155
self.state_logger = logs.get_record_logger_for(execution_uid)

openhtf/output/servers/station_server.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,13 @@ class StationPubSub(pub_sub.PubSub):
273273
"""
274274
_lock = threading.Lock() # Required by pub_sub.PubSub.
275275
subscribers = set() # Required by pub_sub.PubSub.
276-
_last_execution_uid = None
277276
_last_message = None
278277

279278
@classmethod
280279
def publish_test_record(cls, test_record):
281280
test_record_dict = data.convert_to_base_types(test_record)
282281
test_state_dict = _test_state_from_record(test_record_dict,
283-
cls._last_execution_uid)
282+
test_record.test_uid)
284283
cls._publish_test_state(test_state_dict, 'record')
285284

286285
@classmethod
@@ -296,7 +295,6 @@ def _publish_test_state(cls, test_state_dict, message_type):
296295
'type': message_type,
297296
}
298297
super(StationPubSub, cls).publish(message)
299-
cls._last_execution_uid = test_state_dict['execution_uid']
300298
cls._last_message = message
301299

302300
def on_subscribe(self, info):

test/test_state_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ def test_phase():
9696
'diagnosers': [],
9797
'diagnoses': [],
9898
'log_records': [],
99+
'test_uid': 'testing-123',
99100
},
100101
'plugs': {
101102
'plug_descriptors': {},

0 commit comments

Comments
 (0)