Skip to content

Commit d7a6371

Browse files
committed
Revert "[ASTGen] Transform @_inheritActorContext into a custom attribute with an optional modifier"
This reverts commit c0aca53.
1 parent 237d55e commit d7a6371

File tree

4 files changed

+1
-59
lines changed

4 files changed

+1
-59
lines changed

include/swift/AST/ASTBridging.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,18 +1259,6 @@ BridgedNonisolatedAttr_createParsed(BridgedASTContext cContext,
12591259
BridgedSourceRange cRange,
12601260
BridgedNonIsolatedModifier modifier);
12611261

1262-
enum ENUM_EXTENSIBILITY_ATTR(closed) BridgedInheritActorContextModifier {
1263-
BridgedInheritActorContextModifierNone,
1264-
BridgedInheritActorContextModifierAlways,
1265-
};
1266-
1267-
SWIFT_NAME("BridgedInheritActorContextAttr.createParsed(_:atLoc:range:modifier:)")
1268-
BridgedInheritActorContextAttr
1269-
BridgedInheritActorContextAttr_createParsed(BridgedASTContext cContext,
1270-
BridgedSourceLoc cAtLoc,
1271-
BridgedSourceRange cRange,
1272-
BridgedInheritActorContextModifier modifier);
1273-
12741262
SWIFT_NAME("BridgedObjCAttr.createParsedUnnamed(_:atLoc:attrNameLoc:)")
12751263
BridgedObjCAttr
12761264
BridgedObjCAttr_createParsedUnnamed(BridgedASTContext cContext,

lib/AST/Bridging/DeclAttributeBridging.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -649,25 +649,6 @@ BridgedNonisolatedAttr_createParsed(BridgedASTContext cContext,
649649
/*implicit=*/false);
650650
}
651651

652-
static InheritActorContextModifier
653-
unbridged(BridgedInheritActorContextModifier modifier) {
654-
switch (modifier) {
655-
case BridgedInheritActorContextModifierNone:
656-
return InheritActorContextModifier::None;
657-
case BridgedInheritActorContextModifierAlways:
658-
return InheritActorContextModifier::Always;
659-
}
660-
llvm_unreachable("unhandled enum value");
661-
}
662-
663-
BridgedInheritActorContextAttr BridgedInheritActorContextAttr_createParsed(
664-
BridgedASTContext cContext, BridgedSourceLoc cAtLoc,
665-
BridgedSourceRange cRange, BridgedInheritActorContextModifier modifier) {
666-
return new (cContext.unbridged()) InheritActorContextAttr(
667-
cAtLoc.unbridged(), cRange.unbridged(), unbridged(modifier),
668-
/*implicit=*/false);
669-
}
670-
671652
BridgedObjCAttr
672653
BridgedObjCAttr_createParsedUnnamed(BridgedASTContext cContext,
673654
BridgedSourceLoc cAtLoc,

lib/ASTGen/Sources/ASTGen/DeclAttrs.swift

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ extension ASTGenVisitor {
249249
.ibSegueAction,
250250
.implementationOnly,
251251
.implicitSelfCapture,
252+
.inheritActorContext,
252253
.inheritsConvenienceInitializers,
253254
.inlinable,
254255
.isolated,
@@ -311,9 +312,6 @@ extension ASTGenVisitor {
311312
case .referenceOwnership:
312313
// TODO: Diagnose.
313314
return handle(self.generateReferenceOwnershipAttr(attribute: node, attrName: attrName)?.asDeclAttribute)
314-
case .inheritActorContext:
315-
return handle(self.generateInheritActorContextAttr(attribute: node)?.asDeclAttribute)
316-
317315
case .async,
318316
.consuming,
319317
.borrowing,
@@ -1413,28 +1411,6 @@ extension ASTGenVisitor {
14131411
)
14141412
}
14151413

1416-
func generateInheritActorContextAttr(attribute node: AttributeSyntax) -> BridgedInheritActorContextAttr? {
1417-
let modifier: BridgedInheritActorContextModifier? = self.generateSingleAttrOption(
1418-
attribute: node,
1419-
{
1420-
switch $0.rawText {
1421-
case "always": return .always
1422-
default: return nil
1423-
}
1424-
},
1425-
valueIfOmitted: BridgedInheritActorContextModifier.none
1426-
)
1427-
guard let modifier else {
1428-
return nil
1429-
}
1430-
return .createParsed(
1431-
self.ctx,
1432-
atLoc: self.generateSourceLoc(node.atSign),
1433-
range: self.generateAttrSourceRange(node),
1434-
modifier: modifier
1435-
)
1436-
}
1437-
14381414
/// E.g.:
14391415
/// ```
14401416
/// @objc

test/ASTGen/attrs.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,3 @@ struct LayoutOuter {
256256
struct AnyEraser: EraserProto {
257257
init<T: EraserProto>(erasing: T) {}
258258
}
259-
260-
func takeNone(@_inheritActorContext param: () async -> ()) { }
261-
func takeAlways(@_inheritActorContext(always) param: () async -> ()) { }

0 commit comments

Comments
 (0)