Issues with CompilerPass and dotenv variables in non DEV environments

[fnagel]

I've integrated the https://github.com/sulu/SuluArticleBundle bundle in my existing Sulu CMS project. ArticleBundle has a dependency to this package.

Locally (in the DEV environment) everything works fine but when I deploy everything to my STAGE server in order to show it to my client, I got an error on composer install (more specific: the clear cache script running after installing the packages):

In Dsn.php line 48: The mailer DSN must contain a scheme.

I can reproduce this locally as soon as my APP_ENV is stage or prod. Locally I'm using MailHog for catching mails, so the MAILER_DSN env variable should be smtp://mailhog:1025, but as soon as I change the to APP_ENV=stage, its env_4629ca8b26cb32bb_MAILER_DSN_5e62afca55f2f3bd1c033c3715bf615e (output from the \Symfony\Component\Mailer\Transport\Dsn::fromString).

It seems this is related to this #32 change in the compiler repository pass class: https://github.com/handcraftedinthealps/ElasticsearchBundle/blob/5.x/DependencyInjection/Compiler/RepositoryPass.php

If I remove the content of the file, everything works again. I assume its related to caching in non DEV environments but wasn't able to figure out what exactly is the issue here.

Can somebody help? Maybe @alexander-schranz?

Here is my composer.lock file: composer.lock.json

[alexander-schranz]

The MAILER_DSN should be always defined they changes that last year in Symfony itself. See symfony/recipes#1352

Run composer recipes:update to update the symfony mailer recipe or just define the var in .env.

[fnagel]

Thanks for the quick answer!

MAILER_DNS is defined in the .env file. And it works (with the ArticleBundle) locally and on the DEV server. Only if the APP_ENV is stage or prod, it will fail.

Running composer recipes:update will output All packages appear to be up-to-date!, so the recipes should be fine.

[alexander-schranz]

Can you try to create a small reproducer branch. Think easiest way is using the sulu-demo: https://github.com/sulu/sulu-demo and update the dependency that it matches your project to recreate the issue.

[fnagel]

I can try to reproduce it there, but the demo is using Sulu 2.6.x and I'm still using 2.5.x, so I would start from this commit: sulu/sulu-demo@9f23be2

[fnagel]

I was not able to reproduce it in the demo :-( Played with the installed packages, versions and configuration but no error occurred.

Might be something im my configuration but I triple checked everything and when downgrading handcraftedinthealps/elasticsearch-bundle from 5.4.4 to 5.4.2 it works again. Seems to be related to the PR I've linked above and some project specific configuration.

It's not only the mailer configuration but other env variables too (for example Sentry DSN). Seems the env variables are messed up as soon as I have that compiler pass change integrated.

Not sure how to debug this more. Any ideas?

[alexander-schranz]

did you try to use your composer.lock inside sulu demo and just run composer install ontop of that?

[fnagel]

Just did, but it does not work as some needed packages are not present in my projects lock file:

- Required package "league/flysystem" is not present in the lock file.
- Required package "league/flysystem-aws-s3-v3" is not present in the lock file.
- Required package "sulu/web-twig" is not present in the lock file.
- Required package "predis/predis" is not present in the lock file.
- Required package "sulu/automation-bundle" is not present in the lock file.

[alexander-schranz]

@fnagel try to run composer update php which should just install that packages but not update the other dependency.

[fnagel]

@alexander-schranz Does not work either, even with "--with-all-dependencies (-W)":

composer update php -W
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "6.4.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires rector/rector ^1.0, found rector/rector[1.0.0, ..., 1.2.10] but the package is fixed to 0.17.13 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
  Problem 2
    - Root composer.json requires sulu/sulu-rector ^1.0, found sulu/sulu-rector[1.0.0] but the package is fixed to 0.1.6 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

but using composer update php rector/rector sulu/sulu-rector worked!

---

After the composer update the demo is usable and there is no env variables error on cache clear with handcraftedinthealps/elasticsearch-bundle in v5.4.4 and APP_ENV=stage.

I would say this confirms my conclusion that it's not only the compiler pass change but something specific to my projects configuration. Sadly I'm not able to figure out what exactly is the issue :-/

[FlorianKoerner]

We had the same problem. We had to fix the version of the elasticsearch bundle to version 5.4.2 because the problems started with version 5.4.3.

Starting with version 5.4.3, various environment variables can no longer be resolved. Sentry, Redis, etc.

We came to the same conclusion: The change from #32 is responsible for the problems. The problem is that we cannot provide a project in which the problem can be reproduced. I'm glad to hear that we are not the only ones with this problem.

[alexander-schranz]

Can somebody create a reproducer based on https://github.com/sulu/sulu-demo ?