Skip to content

Commit ce1f2ab

Browse files
mohd-akramjaylinski
authored andcommitted
Drop support for EOL Node.js versions
1 parent 2afecb2 commit ce1f2ab

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,6 @@ jobs:
2525
- name: Lint
2626
run: npm run lint
2727

28-
dependencies:
29-
name: Test (dependencies)
30-
runs-on: 'ubuntu-latest'
31-
steps:
32-
- name: Checkout
33-
uses: actions/checkout@v2
34-
35-
- name: Setup Node.js
36-
uses: actions/setup-node@v2
37-
with:
38-
# Node 14 ships with npm v6, which doesn't install peer-dependencies by default.
39-
# Starting with npm v7 (which is shipped with Node >= 16), peer-dependencies are
40-
# automatically installed. So this test (check for unmet peer-dependencies) only
41-
# works with Node <= 14.
42-
node-version: '14'
43-
44-
# Simulate an installation by a dependent package
45-
- name: Install dependencies
46-
run: |
47-
rm package-lock.json
48-
npm install --production
49-
50-
- name: Check dependency tree
51-
run: npm ls
52-
5328
test:
5429
name: Test (Node)
5530
runs-on: ${{ matrix.operating-system }}
@@ -58,7 +33,7 @@ jobs:
5833
matrix:
5934
operating-system: ['ubuntu-latest', 'windows-latest']
6035
# https://nodejs.org/en/about/releases/
61-
node-version: ['12', '14', '16', '18', '20']
36+
node-version: ['18', '20']
6237

6338
steps:
6439
- name: Checkout

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"license": "MIT",
1818
"readmeFilename": "README.markdown",
1919
"engines": {
20-
"node": ">=12"
20+
"node": ">=18"
2121
},
2222
"dependencies": {
2323
"@handlebars/parser": "^2.1.0",

tests/integration/multi-nodejs-test/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
1414
unset npm_config_prefix
1515

1616
echo "Handlebars should be able to run in various versions of NodeJS"
17-
for node_version_to_test in 12 14 16 18; do
17+
for node_version_to_test in 18 20; do
1818

1919
rm -rf target node_modules package-lock.json
2020
mkdir target

0 commit comments

Comments
 (0)