Skip to content

Commit f202c50

Browse files
committed
Pass correct environment for AWS S3 publishing
See #1972
1 parent bb55dea commit f202c50

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
publish-aws-s3:
1212
name: Publish to AWS S3
1313
runs-on: 'ubuntu-latest'
14+
environment: 'builds.handlebarsjs.com.s3.amazonaws.com'
1415
steps:
1516
- name: Checkout
1617
uses: actions/checkout@v2
@@ -31,6 +32,6 @@ jobs:
3132
git config --global user.name "handlebars-lang"
3233
npm run publish:aws
3334
env:
34-
# Note: the environment secrets `S3_ACCESS_KEY_ID`
35-
# and `S3_SECRET_ACCESS_KEY` have to be set!
3635
S3_BUCKET_NAME: "builds.handlebarsjs.com"
36+
S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }}
37+
S3_SECRET_ACCESS_KEY: ${{ secrets.S3_SECRET_ACCESS_KEY }}

0 commit comments

Comments
 (0)