Add tests for undo/redo renameSheet()

Author: sequba

src/DependencyGraph/DependencyGraph.ts

@@ -346,8 +346,8 @@ export class DependencyGraph {
    * - vertices may have dependents in placeholderSheetToDelete and other sheets,
    */
   public mergeSheets(sheetToKeep: number, placeholderSheetToDelete: number): void {
-    this.adjustRangeVerticesWhenMergingSheets(sheetToKeep, placeholderSheetToDelete)
-    this.adjustCellVerticesWhenMergingSheets(sheetToKeep, placeholderSheetToDelete)
+    this.mergeRangeVertices(sheetToKeep, placeholderSheetToDelete)
+    this.mergeCellVertices(sheetToKeep, placeholderSheetToDelete)
     this.addressMapping.removeSheet(placeholderSheetToDelete)
     this.addStructuralNodesToChangeSet()
   }
@@ -787,7 +787,7 @@ export class DependencyGraph {
    * - removes range vertex from graph and range mapping
    * - cleans up dependencies of the removed vertex
    */
-  private adjustRangeVerticesWhenMergingSheets(sheetToKeep: number, placeholderSheetToDelete: number): void {
+  private mergeRangeVertices(sheetToKeep: number, placeholderSheetToDelete: number): void {
     const rangeVertices = Array.from(this.rangeMapping.rangesInSheet(placeholderSheetToDelete))
 
     for (const vertexToDelete of rangeVertices) {
@@ -826,7 +826,7 @@ export class DependencyGraph {
    * - removes cell vertex from graph and address mapping
    * - cleans up dependencies of the removed vertex
    */
-  private adjustCellVerticesWhenMergingSheets(sheetToKeep: number, placeholderSheetToDelete: number): void {
+  private mergeCellVertices(sheetToKeep: number, placeholderSheetToDelete: number): void {
     const cellVertices = Array.from(this.addressMapping.sheetEntries(placeholderSheetToDelete))
 
     for (const [addressToDelete, vertexToDelete] of cellVertices) {

test/unit/cruds/adding-sheet.spec.ts

@@ -579,18 +579,3 @@ describe('recalculates formulas after adding new sheet (issue #1116)', () => {
     })
   })
 })
-
-// IMPLEMENTATION PLAN:
-// - [x] during parseing dont create ERROR vertex - instead add a placeholder shett to sheetMapping and addressMapping
-// - [x] handle this non-error vertec when reading cell (similar to not-added named expressions?)
-// - [x] unit tests: addSheet + ranges, with and without quotes (completed a week ago)
-// - [x] handle addSheet
-// - [x] comprehensive range testing
-// - [x] unit tests: removeSheet + ranges
-// - [x] handle removeSheet
-// - [x] unit tests: renameSheet + ranges
-// - [x] handle renameSheet
-// - [x] refactor
-// - [ ] unit tests: undo-redo
-// - [ ] handle undo-redo
-// - [ ] agent review