Skip to content

Commit 7364bdb

Browse files
committed
Andjust tests for in ]compute-hash-from-tokens.spec.ts
1 parent fd49e9f commit 7364bdb

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/parser/addressRepresentationConverters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const cellAddressFromString = (stringAddress: string, baseAddress: Simple
3535
const sheetName = extractSheetName(result)
3636
let sheet: Maybe<number>
3737

38-
// TODO: refactor
38+
// TODO: refactor getter/converter should not do actions like reserve/add
3939
if (sheetName) {
4040
sheet = sheetMapping.reserveSheetName(sheetName)
4141
addressMapping.addSheetStrategyPlaceholderIfNotExists(sheet)

test/unit/cruds/adding-sheet.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ describe('add sheet to engine', () => {
107107
}).toThrow(new SheetNameAlreadyTakenError('bar'))
108108
})
109109

110-
it.only('recalculates the cells referencing the new sheet (#1116)', () => {
110+
it('recalculates the cells referencing the new sheet (#1116)', () => {
111111
const engine = HyperFormula.buildEmpty()
112112
const table1Name = 'table1'
113113
const table2Name = 'table2'

test/unit/parser/compute-hash-from-tokens.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe('computeHashFromTokens', () => {
8080
it('cell ref to not exsiting sheet', () => {
8181
const code = '=Sheet3!A1'
8282

83-
expect(computeFunc(code, adr('B2'))).toEqual('=Sheet3!A1')
83+
expect(computeFunc(code, adr('B2'))).toBe('=#2#-1R-1')
8484
})
8585

8686
it('cell range', () => {

0 commit comments

Comments
 (0)