Move to C++17

Author: thiagowinkler

CMakeLists.txt

@@ -1,8 +1,8 @@
-### CMake Version #############################################################
+### CMake Version ##############################################################
 
 cmake_minimum_required(VERSION 3.10)
 
-### Project Configuration #####################################################
+### Project Configuration ######################################################
 
 get_filename_component(PROJECT_DIR_NAME ${CMAKE_CURRENT_LIST_DIR} NAME)
 string(REPLACE " " "_" PROJECT_DIR_NAME ${PROJECT_DIR_NAME})
@@ -13,7 +13,7 @@ project(${PROJECT_DIR_NAME}
 
 set(LIB_NAME shift)
 
-### List of Files #############################################################
+### List of Files ##############################################################
 
 set(DEMO
     ${PROJECT_SOURCE_DIR}/demo/credentials.py
@@ -45,15 +45,16 @@ set(OTHER
     ${PROJECT_SOURCE_DIR}/setup.py
 )
 
-### Compiler Flags ############################################################
+### Compiler Flags #############################################################
 
 # Important for libraries
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
-# C++14
-set(CMAKE_CXX_STANDARD 14)
+# C++17
+set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
+add_definitions("-DHAVE_STD_UNIQUE_PTR=1") # QuickFIX C++17 compatibility req.
 
 # Common Flags
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fexceptions -pedantic-errors")
@@ -68,7 +69,7 @@ set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG -finline-functions -flto")
 
 # GCC (Ubuntu 18.04 LTS Bionic Beaver)
 if(UNIX AND NOT APPLE)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
 endif(UNIX AND NOT APPLE)
 
 # GCC (Raspbian Buster for Raspberry Pi 4)
@@ -79,19 +80,18 @@ endif(${CMAKE_SYSTEM_PROCESSOR} MATCHES "armv7l")
 
 # Clang (macOS Catalina 10.15)
 if(APPLE)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-overloaded-virtual")
     include_directories(/usr/local/include)
 endif(APPLE)
 
-### Build Types ###############################################################
+### Build Types ################################################################
 
 # if no build type is set, the default is Release
 if(NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE Release)
 endif(NOT CMAKE_BUILD_TYPE)
 
-### Build Configuration #######################################################
+### Build Configuration ########################################################
 
 find_package(pybind11 REQUIRED)
 
@@ -118,4 +118,4 @@ target_include_directories(${LIB_NAME}
 target_link_libraries(${LIB_NAME}
                       PRIVATE ${LIBCORECLIENT})
 
-###############################################################################
+################################################################################

DeveloperGuide.html

@@ -675,7 +675,7 @@ <h4 id="pybind11">pybind11:</h4>
 <a class="sourceLine" id="cb1-3" data-line-number="3"><span class="fu">git</span> checkout tags/v2.2.4 <span class="co"># v2.3.0 has a bug with char enums</span></a>
 <a class="sourceLine" id="cb1-4" data-line-number="4"><span class="fu">mkdir</span> build</a>
 <a class="sourceLine" id="cb1-5" data-line-number="5"><span class="bu">cd</span> build</a>
-<a class="sourceLine" id="cb1-6" data-line-number="6"><span class="fu">cmake</span> -DPYBIND11_PYTHON_VERSION=3.7 ..</a>
+<a class="sourceLine" id="cb1-6" data-line-number="6"><span class="fu">cmake</span> -DCMAKE_CXX_STANDARD=17 -DPYBIND11_PYTHON_VERSION=3.7 ..</a>
 <a class="sourceLine" id="cb1-7" data-line-number="7"><span class="fu">make</span></a>
 <a class="sourceLine" id="cb1-8" data-line-number="8"><span class="fu">sudo</span> make install</a></code></pre></div>
 <hr />

DeveloperGuide.md

@@ -25,7 +25,7 @@ cd pybind11
 git checkout tags/v2.2.4 # v2.3.0 has a bug with char enums
 mkdir build
 cd build
-cmake -DPYBIND11_PYTHON_VERSION=3.7 ..
+cmake -DCMAKE_CXX_STANDARD=17 -DPYBIND11_PYTHON_VERSION=3.7 ..
 make
 sudo make install
 ```