Skip to content

Commit 6d61c8b

Browse files
authored
Merge pull request #85 from prashantsaini1/main
chore(android): upgrade `analytics` to 22.2.0 and `installations` to …
2 parents 780f0b4 + 6472f23 commit 6d61c8b

File tree

4 files changed

+13
-20
lines changed

4 files changed

+13
-20
lines changed

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ repositories {
33
}
44

55
dependencies {
6-
implementation 'com.google.firebase:firebase-analytics:21.0.0'
7-
implementation 'com.google.firebase:firebase-installations:17.0.1'
6+
implementation 'com.google.firebase:firebase-analytics:22.2.0'
7+
implementation 'com.google.firebase:firebase-installations:18.0.0'
88
}

android/manifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# this is your module manifest and used by Titanium
33
# during compilation, packaging, distribution, etc.
44
#
5-
version: 5.2.0
5+
version: 5.3.0
66
apiversion: 4
77
architectures: arm64-v8a armeabi-v7a x86 x86_64
88
description: titanium-firebase-analytics

android/src/firebase/analytics/TitaniumFirebaseAnalyticsModule.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -126,25 +126,21 @@ public void setScreenNameAndScreenClass(KrollDict parameters)
126126
final String screenClass = parameters.getString("screenClass");
127127
final FirebaseAnalytics instance = analyticsInstance();
128128

129-
getActivity().runOnUiThread(new Runnable() {
130-
@Override
131-
public void run()
132-
{
133-
Bundle bundle = new Bundle(1);
134-
135-
bundle.putString(FirebaseAnalytics.Param.SCREEN_NAME, screenName);
136-
if (screenClass != null) {
137-
bundle.putString(FirebaseAnalytics.Param.SCREEN_CLASS, screenClass);
138-
}
129+
getActivity().runOnUiThread(() -> {
130+
Bundle bundle = new Bundle(1);
139131

140-
instance.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW, bundle);
141-
}
142-
});
132+
bundle.putString(FirebaseAnalytics.Param.SCREEN_NAME, screenName);
133+
if (screenClass != null) {
134+
bundle.putString(FirebaseAnalytics.Param.SCREEN_CLASS, screenClass);
135+
}
136+
137+
instance.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW, bundle);
138+
});
143139
}
144140

145141
private Bundle mapToBundle(Map<String, Object> map)
146142
{
147-
if (map == null || map.size() == 0)
143+
if (map == null || map.isEmpty())
148144
return null;
149145

150146
Bundle bundle = new Bundle(map.size());

android/timodule.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<ti:module xmlns:ti="http://ti.appcelerator.org" xmlns:android="http://schemas.android.com/apk/res/android">
33
<modules>
4-
<!-- Require Firebase Core (https://github.com/hansemannn/titanium-firebase-core) -->
5-
<module platform="android">firebase.core</module>
6-
74
<!-- Require Ti.PlayServices (https://github.com/appcelerator-modules/ti.playservices) -->
85
<module platform="android">ti.playservices</module>
96
</modules>

0 commit comments

Comments
 (0)