Revert "Make neuron_installed helper function more generic and add changelog"

This reverts commit cbed2e7

Signed-off-by: Francesco Giordano <[email protected]>

Author: francesco-giordano

CHANGELOG.md

@@ -7,7 +7,6 @@ This file is used to list changes made in each version of the AWS ParallelCluste
 ------
 
 **ENHANCEMENTS**
-- Add support for AWS Trainium instances.
 - Add support for Slurm Accounting.
 - Add support for adding and removing shared storages at cluster update.
 - Add possibility to specify multiple instance types for the same compute resource.

cookbooks/aws-parallelcluster-install/recipes/neuron.rb

@@ -15,7 +15,7 @@
 # OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
 # limitations under the License.
 
-return if node['cluster']['base_os'] == 'centos7' || arm_instance? || is_package_installed?("aws-neuronx-dkms")
+return if node['cluster']['base_os'] == 'centos7' || arm_instance? || neuron_installed?
 
 if platform?('amazon')
   # add neuron repository

libraries/helpers.rb

@@ -541,19 +541,18 @@ def efa_installed?
   dir_exist
 end
 
-def is_package_installed?(package_name)
+def neuron_installed?
+  package_name = "aws-neuronx-dkms"
   command = value_for_platform(
-    %w(ubuntu debian) => {
-      'default' => "apt list --installed | grep #{package_name}",
-    },
-    'default' => "yum list installed | grep #{package_name}"
-  )
+  %w(ubuntu debian) => {
+    'default' => "apt list --installed | grep #{package_name}",
+  },
+  'default' => "yum list installed | grep #{package_name}")
 
   cmd = Mixlib::ShellOut.new(command, timeout: 60)
   cmd.run_command
-  Chef::Log.info("Checking if #{package_name} is installed...\n#{command}\n#{cmd.stdout.strip}")
-  # Convert return code to boolean
-  cmd.exitstatus.to_i.zero?
+  # Return false if the package is not installed
+  !(cmd.exitstatus != 0)
 end
 
 def is_neuron_instance?