fix: spurious update plans for float attributes after import

Author: stainless-app[bot]

internal/apiform/form_test.go

@@ -17,6 +17,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/types/basetypes"
 
 	"github.com/hanzoai/terraform-provider-hanzo/internal/customfield"
+	type_helpers "github.com/hanzoai/terraform-provider-hanzo/internal/types"
 )
 
 func P[T any](v T) *T { return &v }
@@ -325,7 +326,7 @@ Content-Type: application/json
 		TerraformTypes{
 			A: types.BoolValue(true),
 			B: types.Int64Value(237628372683),
-			C: types.Float64Value(654),
+			C: type_helpers.NewFloat64ValueFromStringUnsafe("654"),
 			D: types.StringValue("a string value"),
 			E: timetypes.NewRFC3339TimeValue(time.Date(2006, time.January, 2, 15, 4, 5, 0, time.UTC)),
 			F: customfield.NewObjectMust(context.TODO(), &NestedTerraformType{
@@ -334,7 +335,7 @@ Content-Type: application/json
 			G: types.ObjectValueMust(map[string]attr.Type{"hello": basetypes.StringType{}}, map[string]attr.Value{"hello": basetypes.NewStringValue("world")}),
 			H: types.ListValueMust(basetypes.StringType{}, []attr.Value{basetypes.NewStringValue("a"), basetypes.NewStringValue("b")}),
 			I: types.MapValueMust(basetypes.Int64Type{}, map[string]attr.Value{"a": basetypes.NewInt64Value(3), "b": basetypes.NewInt64Value(8932)}),
-			J: types.SetValueMust(basetypes.Float64Type{}, []attr.Value{basetypes.NewFloat64Value(23.345), basetypes.NewFloat64Value(15)}),
+			J: types.SetValueMust(basetypes.Float64Type{}, []attr.Value{type_helpers.NewFloat64ValueFromStringUnsafe("23.345"), type_helpers.NewFloat64ValueFromStringUnsafe("15")}),
 			K: types.DynamicValue(types.ObjectValueMust(map[string]attr.Type{"dynamic_hello": basetypes.StringType{}}, map[string]attr.Value{"dynamic_hello": basetypes.NewStringValue("dynamic_world")})),
 			L: customfield.NewListMust[types.String](context.TODO(), []attr.Value{basetypes.NewStringValue("a"), basetypes.NewStringValue("b")}),
 			M: customfield.NewMapMust[types.String](context.TODO(), map[string]types.String{"a": basetypes.NewStringValue("3"), "b": basetypes.NewStringValue("8932")}),

internal/apijson/decoder.go

@@ -3,6 +3,7 @@ package apijson
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"math/big"
 	"reflect"
@@ -19,6 +20,7 @@ import (
 	"github.com/tidwall/gjson"
 
 	"github.com/hanzoai/terraform-provider-hanzo/internal/customfield"
+	type_helpers "github.com/hanzoai/terraform-provider-hanzo/internal/types"
 )
 
 // decoders is a synchronized map with roughly the following type:
@@ -478,23 +480,44 @@ func (d *decoderBuilder) newTerraformTypeDecoder(t reflect.Type) decoderFunc {
 
 	if (t == reflect.TypeOf(basetypes.Float64Value{})) {
 		return d.decodeTerraformPrimitive(func() any { return types.Float64Null() }, func(node gjson.Result, value reflect.Value, state *decoderState) error {
-			// use ParseFloat just to validate that it's a valid number
-			_, err := strconv.ParseFloat(node.Str, 64)
-			if node.Type == gjson.JSON || (node.Type == gjson.String && err != nil) {
-				return fmt.Errorf("apijson: failed to parse types.Float64Value")
+			var rawVal string
+			switch node.Type {
+			case gjson.String:
+				rawVal = node.Str
+			case gjson.Number:
+				rawVal = node.Raw
+			default:
+				return errors.New("apijson: failed to parse as basetypes.Float64Value")
 			}
-			value.Set(reflect.ValueOf(types.Float64Value(node.Float())))
+
+			f64Val, err := type_helpers.NewFloat64ValueFromString(rawVal)
+			if err != nil {
+				return fmt.Errorf("apijson: %w", err)
+			}
+
+			value.Set(reflect.ValueOf(f64Val))
 			return nil
 		})
 	}
 
 	if (t == reflect.TypeOf(basetypes.NumberValue{})) {
 		return d.decodeTerraformPrimitive(func() any { return types.NumberNull() }, func(node gjson.Result, value reflect.Value, state *decoderState) error {
-			value.Set(reflect.ValueOf(types.NumberValue(big.NewFloat(node.Float()))))
-			_, err := strconv.ParseFloat(node.Str, 64)
-			if node.Type == gjson.JSON || (node.Type == gjson.String && err != nil) {
-				return fmt.Errorf("apijson: failed to parse types.Float64Value")
+			var rawVal string
+			switch node.Type {
+			case gjson.String:
+				rawVal = node.Str
+			case gjson.Number:
+				rawVal = node.Raw
+			default:
+				return errors.New("apijson: failed to parse as basetypes.NumberValue")
 			}
+
+			numberVal, err := type_helpers.NewNumberValueFromString(rawVal)
+			if err != nil {
+				return fmt.Errorf("apijson: %w", err)
+			}
+
+			value.Set(reflect.ValueOf(numberVal))
 			return nil
 		})
 	}
@@ -1350,7 +1373,7 @@ func (d *decoderBuilder) inferTerraformAttrFromValue(node gjson.Result) (attr.Va
 		if err == nil {
 			return types.Int64Value(node.Int()), nil
 		}
-		return types.Float64Value(node.Float()), nil
+		return type_helpers.NewFloat64ValueFromString(node.String())
 	case gjson.String:
 		return types.StringValue(node.String()), nil
 	case gjson.JSON: