Skip to content
This repository was archived by the owner on Oct 18, 2025. It is now read-only.

Commit dd8f9f6

Browse files
committed
window covering compatibility
1 parent a743653 commit dd8f9f6

File tree

1 file changed

+4
-23
lines changed

1 file changed

+4
-23
lines changed

addons/io/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitWindowCoveringImpl.java

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@
1212
import com.beowulfe.hap.accessories.WindowCovering;
1313
import com.beowulfe.hap.accessories.properties.WindowCoveringPositionState;
1414

15-
public class HomekitWindowCoveringImpl extends AbstractHomekitAccessoryImpl<RollershutterItem> implements WindowCovering {
15+
public class HomekitWindowCoveringImpl extends AbstractHomekitAccessoryImpl<RollershutterItem>
16+
implements WindowCovering {
1617

17-
public HomekitWindowCoveringImpl(HomekitTaggedItem taggedItem, ItemRegistry itemRegistry, HomekitAccessoryUpdater updater) {
18+
public HomekitWindowCoveringImpl(HomekitTaggedItem taggedItem, ItemRegistry itemRegistry,
19+
HomekitAccessoryUpdater updater) {
1820
super(taggedItem, itemRegistry, updater, RollershutterItem.class);
1921
}
2022

@@ -27,11 +29,6 @@ public CompletableFuture<Integer> getCurrentPosition() {
2729
return CompletableFuture.completedFuture(100 - value.intValue());
2830
}
2931

30-
@Override
31-
public CompletableFuture<Boolean> getObstructionDetected() {
32-
return CompletableFuture.completedFuture(false);
33-
}
34-
3532
@Override
3633
public CompletableFuture<WindowCoveringPositionState> getPositionState() {
3734
return CompletableFuture.completedFuture(WindowCoveringPositionState.STOPPED);
@@ -42,11 +39,6 @@ public CompletableFuture<Integer> getTargetPosition() {
4239
return getCurrentPosition();
4340
}
4441

45-
@Override
46-
public CompletableFuture<Void> setHoldPosition(boolean value) throws Exception {
47-
return CompletableFuture.completedFuture(null);
48-
}
49-
5042
@Override
5143
public CompletableFuture<Void> setTargetPosition(int value) throws Exception {
5244
((RollershutterItem) getItem()).send(new PercentType(100 - value));
@@ -58,11 +50,6 @@ public void subscribeCurrentPosition(HomekitCharacteristicChangeCallback callbac
5850
getUpdater().subscribe(getItem(), callback);
5951
}
6052

61-
@Override
62-
public void subscribeObstructionDetected(HomekitCharacteristicChangeCallback callback) {
63-
// Not implemented
64-
}
65-
6653
@Override
6754
public void subscribePositionState(HomekitCharacteristicChangeCallback callback) {
6855
// Not implemented
@@ -78,11 +65,6 @@ public void unsubscribeCurrentPosition() {
7865
getUpdater().unsubscribe(getItem());
7966
}
8067

81-
@Override
82-
public void unsubscribeObstructionDetected() {
83-
// Not implemented
84-
}
85-
8668
@Override
8769
public void unsubscribePositionState() {
8870
// Not implemented
@@ -92,5 +74,4 @@ public void unsubscribePositionState() {
9274
public void unsubscribeTargetPosition() {
9375
getUpdater().unsubscribe(getItem(), "targetPosition");
9476
}
95-
9677
}

0 commit comments

Comments
 (0)