STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails (#7340)

* STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails

* Add changelog

---------

Co-authored-by: James Agnew <[email protected]>

Author: elavy-harris

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_8_0/7340-storage-transaction-processing-wrong-type.yaml

@@ -0,0 +1,7 @@
+---
+type: fix
+issue: 7340
+title: "The JPA FHIR transaction processor had a bug when processing the
+   `STORAGE_TRANSACTION_PROCESSING` interceptor pointcut, preventing
+   hook methods from supplying parameter values of type ServletRequestDetails.
+   Thanks to Elliott Lavy for the contribution!"

hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/dao/BaseTransactionProcessor.java

@@ -247,7 +247,7 @@ public <BUNDLE extends IBaseBundle> BUNDLE transaction(
 		if (compositeBroadcaster.hasHooks(Pointcut.STORAGE_TRANSACTION_PROCESSING)) {
 			HookParams params = new HookParams()
 					.add(RequestDetails.class, theRequestDetails)
-					.addIfMatchesType(ServletRequestDetails.class, theRequest)
+					.addIfMatchesType(ServletRequestDetails.class, theRequestDetails)
 					.add(IBaseBundle.class, theRequest);
 			compositeBroadcaster.callHooks(Pointcut.STORAGE_TRANSACTION_PROCESSING, params);
 		}