Fix transaction conditional URL prefetch on non-token params (#6818)

* Fix transaction conditional URL prefetch on non-token params

* Drop a check

* Adjust query counts

* Improve performance

* Single token optimized

* Test fixes

* About to try to ensure we prefetch resource bodies for conditional create

* Test fixes

* Some test fixes

* Test fixes

* Test fixes

* Test fixes

* Work on tests

* Test fix

* Spotless

* Add docs

* Address review comments

Author: jamesagnew

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_2_0/6818-handle-transaction-conditional-non-token-urls.yaml

@@ -0,0 +1,7 @@
+---
+type: fix
+issue: 6818
+title: "When performing a conditional create/update/etc in a FHIR transaction, if the conditional
+   URL had parameters with a type other than `token`, the transaction processor could fail with
+   a constraint error if the target already existed. This has been corrected. Thanks to
+   Brian Lind for reporting!"

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_2_0/6818-improve-transaction-conditional-create-performance.yaml

@@ -0,0 +1,6 @@
+---
+type: perf
+issue: 6818
+title: "When executing a FHIR transaction containing multiple conditional create operations,
+   a series of SQL resource version lookups have been collapsed into a single query for
+   better performance."

hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java

@@ -494,14 +494,17 @@ private DaoMethodOutcome doCreateForPostOrPut(
 					Supplier<IIdType> idSupplier = () -> myTxTemplate.execute(tx -> {
 						IIdType retVal = myIdHelperService.translatePidIdToForcedId(myFhirContext, myResourceName, pid);
 						if (!retVal.hasVersionIdPart()) {
-							Long version = myMemoryCacheService.getIfPresent(
-									MemoryCacheService.CacheEnum.RESOURCE_CONDITIONAL_CREATE_VERSION, pid.getId());
+							Long version = pid.getVersion();
+							if (version == null) {
+								version = myMemoryCacheService.getIfPresent(
+										MemoryCacheService.CacheEnum.RESOURCE_CONDITIONAL_CREATE_VERSION, pid);
+							}
 							if (version == null) {
 								version = myResourceTableDao.findCurrentVersionByPid(pid);
 								if (version != null) {
 									myMemoryCacheService.putAfterCommit(
 											MemoryCacheService.CacheEnum.RESOURCE_CONDITIONAL_CREATE_VERSION,
-											pid.getId(),
+											pid,
 											version);
 								}
 							}