7179 - Fix RequestDetailsCloner (#7180)

* When the originating request is a ServletRequestDetails create a new ServletRequestDetails

* add changelog

Author: barhodes

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_4_0/7179-fix-requestdetailscloner.yaml

@@ -0,0 +1,6 @@
+---
+type: fix
+issue: 7179
+title: "A bug in the class used to copy and reuse the RequestDetails during operations
+ invoked through the HapiFhirRepository would cause an invalid cast exception downstream
+ when authentication interceptors were enabled for the operation.  This has been fixed."

hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/repository/RequestDetailsCloner.java

@@ -24,6 +24,7 @@
 import ca.uhn.fhir.rest.api.RestOperationTypeEnum;
 import ca.uhn.fhir.rest.api.server.RequestDetails;
 import ca.uhn.fhir.rest.api.server.SystemRequestDetails;
+import ca.uhn.fhir.rest.server.servlet.ServletRequestDetails;
 import org.hl7.fhir.instance.model.api.IBaseParameters;
 import org.hl7.fhir.instance.model.api.IIdType;
 
@@ -40,7 +41,12 @@ class RequestDetailsCloner {
 	private RequestDetailsCloner() {}
 
 	static DetailsBuilder startWith(RequestDetails theDetails) {
-		SystemRequestDetails newDetails = new SystemRequestDetails(theDetails);
+		RequestDetails newDetails;
+		if (theDetails instanceof ServletRequestDetails servletDetails) {
+			newDetails = new ServletRequestDetails(servletDetails);
+		} else {
+			newDetails = new SystemRequestDetails(theDetails);
+		}
 		newDetails.setRequestType(RequestTypeEnum.POST);
 		newDetails.setOperation(null);
 		newDetails.setResource(null);
@@ -53,9 +59,9 @@ static DetailsBuilder startWith(RequestDetails theDetails) {
 	}
 
 	static class DetailsBuilder {
-		private final SystemRequestDetails myDetails;
+		private final RequestDetails myDetails;
 
-		DetailsBuilder(SystemRequestDetails theDetails) {
+		DetailsBuilder(RequestDetails theDetails) {
 			myDetails = theDetails;
 		}
 
@@ -112,7 +118,7 @@ DetailsBuilder setId(IIdType theId) {
 			return this;
 		}
 
-		SystemRequestDetails create() {
+		RequestDetails create() {
 			return myDetails;
 		}
 	}