Skip to content

Fix package installation in Partitioning Mode #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix package installation in Partitioning Mode #7376

wants to merge 3 commits into from
+44 −4

Conversation

@patrick-werner
Copy link
Member

@patrick-werner patrick-werner commented Nov 12, 2025 •
edited
Loading

Description
This PR addresses issue #7375, which caused package installation to fail in partitioning mode when using the STORE_AND_INSTALL process. The error occurred due to a non-partitionable resource being written to a partition.

Changes

  • Thread the configured default partition through PackageInstallerSvcImpl: package existence checks and DAO create/update calls now use PartitionSettings#getDefaultRequestPartitionId() via SystemRequestDetails.
  • Expose createRequestDetails() for tests and add unit coverage to ensure it returns a SystemRequestDetails pinned to the configured default partition ID.
  • Add a regression test exercising a package installation in partitioning mode, verifying that DAO writes receive the correct partition-scoped request details.

fixes #7375

@robogary
Copy link
Contributor

robogary commented Nov 12, 2025

Formatting check succeeded!

@patrick-werner patrick-werner force-pushed the fix-packageInstallation-withPartitions-7375 branch from b58b7bb to 85052d7 Compare November 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jkiddo jkiddo jkiddo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in Partitioning with STORE_AND_INSTALL Package installations

4 participants

@patrick-werner @robogary @jkiddo