Code cleanup (#236)

* Misc warning fixes

* Update js code

Author: dotasek

src/jsMain/kotlin/reactredux/store/Store.kt

@@ -13,7 +13,7 @@ val myStore = createStore<AppState, RAction, dynamic>(
     compose(
         rThunk(),
         rEnhancer(),
-        js("if(window.__REDUX_DEVTOOLS_EXTENSION__ )window.__REDUX_DEVTOOLS_EXTENSION__ ();else(function(f){return f;});")
+        js("window.__REDUX_DEVTOOLS_EXTENSION__ ? window.__REDUX_DEVTOOLS_EXTENSION__() : (function(f){return f;})")
     )
 )
 

src/jsMain/kotlin/ui/components/validation/codeissuedisplay/CodeIssueDisplay.kt

@@ -94,7 +94,7 @@ class CodeIssueDisplay : RComponent<CodeIssueDisplayProps, CodeIssueDisplayState
                 0,
                 message.getLine(),
                 0,
-                issueSeverityToAceCSSClasses(message.getLevel(), props.highlightedMessages?.contains(message)),
+                issueSeverityToAceCSSClasses(message.getLevel(), props.highlightedMessages.contains(message)),
                 "line",
                 true
             )

src/jsMain/kotlin/utils/ValidationUtils.kt

@@ -14,6 +14,7 @@ fun getHighestIssueSeverity(validationMessages: List<ValidationMessage>): IssueS
             IssueSeverity.WARNING -> warning = true
             IssueSeverity.ERROR -> error = true
             IssueSeverity.FATAL -> return IssueSeverity.FATAL
+            else -> {}
         }
     }
 

src/jvmMain/kotlin/Server.kt

@@ -47,8 +47,7 @@ fun startServer(args: Array<String>) {
 
     val preloadCache = System.getenv()["PRELOAD_CACHE"] ?: "false"
 
-    if (preloadCache != null && preloadCache.equals("true")) {
-
+    if (preloadCache.equals("true")) {
         Thread(PackageCacheDownloaderRunnable()).start();
     }