Skip to content

Commit 0fa60f0

Browse files
authored
add base package for card and add type in manifest when missing (#90)
* feat: add type filed in manifest when missing for card Signed-off-by: lileirjyb <[email protected]> * fix: add base package for card needed by debugger Signed-off-by: lileirjyb <[email protected]> * fix: update snapshot Signed-off-by: lileirjyb <[email protected]> --------- Signed-off-by: lileirjyb <[email protected]>
1 parent b75db76 commit 0fa60f0

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

packages/hap-packager/src/common/shared.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ function checkFeatureInCard(obj = {}) {
212212
}
213213

214214
/**
215-
* 填充 widget.path 缺失时的默认值
215+
* 填充 widget path、type 缺失时的默认值
216216
*/
217217
function populateWidgetFields(widgetsObj) {
218218
Object.keys(widgetsObj).forEach((key) => {
@@ -222,6 +222,12 @@ function populateWidgetFields(widgetsObj) {
222222
`WARN: manifest.json 文件中 widgets 字段 ${key} 缺少 path 属性,默认设置为卡片名 /${key}`
223223
)
224224
}
225+
if (!widgetsObj[key].type) {
226+
widgetsObj[key].type = `js`
227+
colorconsole.warn(
228+
`WARN: manifest.json 文件中 widgets 字段 ${key} 缺少 type 属性,默认设置为 js`
229+
)
230+
}
225231
})
226232
}
227233

packages/hap-packager/src/process/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ async function buildProjectAndOutput(
129129
}
130130

131131
// 如果不是快应用分包,则移除第一个 base 包
132-
// 只有快应用分包才需要base包,卡片分包不需要
133-
if (!isAppSubpackage && subPackages) {
134-
subPackages.shift()
135-
}
132+
// 只有快应用分包才需要base包,卡片分包不需要 —— update: 卡片需要保留base包,调试器处理rpks时需要读取
133+
// if (!isAppSubpackage && subPackages) {
134+
// subPackages.shift()
135+
// }
136136

137137
// Step1. 生成整包rpk
138138
let fullPackageBuffer = await createZipBufferForPackage(fullPackage)

packages/hap-toolkit/__tests__/__snapshots__/compile.test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,8 @@ versionCode 字段必须为 Integer 类型
306306
307307
[INFO] 获取到app文件后缀: ux
308308
309+
[WARN] WARN: manifest.json 文件中 widgets 字段 CardDemo 缺少 type 属性,默认设置为 js
310+
309311
[INFO] Build Time Cost: : <time-cost>
310312
311313
[LOG] ### App Loader ### 项目构建启用了用户 debug 签名

0 commit comments

Comments
 (0)