BUG/MINOR: consul: fix health_check_policy validation on update

rmaticevic · rmaticevic · commit 5f9f5b14f960 · 2024-12-09T13:30:29.000+01:00
diff --git a/handlers/consul.go b/handlers/consul.go
@@ -141,7 +141,7 @@ func (c *ReplaceConsulHandlerImpl) Handle(params service_discovery.ReplaceConsul
 		return service_discovery.NewReplaceConsulDefault(int(*e.Code)).WithPayload(e)
 	}
 	setFilters(params.Data)
-	if *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {
+	if params.Data.HealthCheckPolicy != nil && *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {
 		e := &models.Error{
 			Message: misc.StringP("health_check_policy_min is required for 'min' health_check_policy"),
 			Code:    misc.Int64P(int(misc.ErrHTTPBadRequest)),

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ func (c *ReplaceConsulHandlerImpl) Handle(params service_discovery.ReplaceConsul`
`141`	`141`	`return service_discovery.NewReplaceConsulDefault(int(*e.Code)).WithPayload(e)`
`142`	`142`	`}`
`143`	`143`	`setFilters(params.Data)`
`144`		`- if *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {`
	`144`	`+ if params.Data.HealthCheckPolicy != nil && *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {`
`145`	`145`	`e := &models.Error{`
`146`	`146`	`Message: misc.StringP("health_check_policy_min is required for 'min' health_check_policy"),`
`147`	`147`	`Code: misc.Int64P(int(misc.ErrHTTPBadRequest)),`