Skip to content

Commit adde4d6

Browse files
committed
CI: Helm v3 requires unit in timeout parameter. More CT fixes.
Signed-off-by: Dinko Korunic <[email protected]>
1 parent b372ef4 commit adde4d6

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.circleci/ct.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
remote: k8s
22
target-branch: master
33
chart-dirs: .
4-
helm-extra-args: --timeout 600
4+
helm-extra-args: --timeout 600s

.circleci/install_charts.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ create_ct_container() {
2020

2121
cleanup() {
2222
echo "Removing ct container"
23-
docker kill ct > /dev/null 2>&1
23+
docker kill ct >/dev/null 2>&1 || true
2424
}
2525

2626
docker_exec() {
27-
docker exec --interactive ct "$@"
27+
docker exec --interactive --tty ct "$@"
2828
}
2929

3030
create_kind_cluster() {
@@ -62,7 +62,7 @@ main() {
6262

6363
echo "Testing for chart repo changes"
6464
local changed
65-
changed=$(docker_exec ct list-changed)
65+
changed=$(docker_exec ct list-changed 2>/dev/null | grep -v "is not a valid chart directory")
6666
if [[ -z "${changed}" ]]; then
6767
echo "No chart changes detected"
6868
return

.circleci/release.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ readonly CHARTS_URL=https://haproxytech.github.io/helm-charts
1616
readonly REPO_ROOT="${REPO_ROOT:-$(git rev-parse --show-toplevel)}"
1717

1818
find_latest_tag() {
19-
if ! git describe --tags --abbrev=0 2> /dev/null; then
19+
if ! git describe --tags --abbrev=0 2>/dev/null; then
2020
git rev-list --max-parents=0 --first-parent HEAD
2121
fi
2222
}
@@ -47,7 +47,7 @@ update_index() {
4747
}
4848

4949
main() {
50-
pushd "${REPO_ROOT}" > /dev/null
50+
pushd "${REPO_ROOT}" >/dev/null
5151

5252
echo "Fetching tags"
5353
git fetch --tags
@@ -90,7 +90,7 @@ main() {
9090
echo "Nothing to do. No chart changes detected."
9191
fi
9292

93-
popd > /dev/null
93+
popd >/dev/null
9494
}
9595

9696
main

0 commit comments

Comments
 (0)