BUG: pprof handler should be run once

Author: ivanmatmati

pkg/controller/handler.go

@@ -52,9 +52,7 @@ func (c *HAProxyController) initHandlers() {
 		&handler.PatternFiles{},
 		&handler.BackendCfgSnippet{},
 	}
-	if c.osArgs.PprofEnabled {
-		c.updateHandlers = append(c.updateHandlers, handler.Pprof{})
-	}
+
 	c.updateHandlers = append(c.updateHandlers, handler.Refresh{})
 }
 
@@ -72,6 +70,9 @@ func (c *HAProxyController) startupHandlers() error {
 			IPv6Addr:  c.osArgs.IPV6BindAddr,
 		},
 	}
+	if c.osArgs.PprofEnabled {
+		handlers = append(handlers, handler.Pprof{})
+	}
 	for _, handler := range handlers {
 		_, err := handler.Update(c.store, c.haproxy, c.annotations)
 		if err != nil {

pkg/handler/pprof.go

@@ -30,7 +30,7 @@ func (handler Pprof) Update(k store.K8s, h haproxy.HAProxy, a annotations.Annota
 
 	_, err = h.BackendGet(pprofBackend)
 	if err != nil {
-		err = h.BackendCreate(models.Backend{
+		err = h.BackendCreatePermanently(models.Backend{
 			Name: pprofBackend,
 			Mode: "http",
 		})

pkg/haproxy/api/api.go

@@ -22,6 +22,8 @@ type HAProxyClient interface { //nolint:interfacebloat
 	BackendsGet() (models.Backends, error)
 	BackendGet(backendName string) (*models.Backend, error)
 	BackendCreate(backend models.Backend) error
+	BackendCreatePermanently(backend models.Backend) error
+	BackendCreateIfNotExist(backend models.Backend) error
 	BackendEdit(backend models.Backend) error
 	BackendDelete(backendName string) error
 	BackendCfgSnippetSet(backendName string, value []string) error
@@ -75,6 +77,7 @@ type HAProxyClient interface { //nolint:interfacebloat
 type clientNative struct {
 	nativeAPI                   clientnative.HAProxyClient
 	activeBackends              map[string]struct{}
+	permanentBackends           map[string]struct{}
 	activeTransaction           string
 	activeTransactionHasChanges bool
 }
@@ -110,8 +113,9 @@ func New(transactionDir, configFile, programPath, runtimeSocket string) (client
 	}
 
 	cn := clientNative{
-		nativeAPI:      cnHAProxyClient,
-		activeBackends: make(map[string]struct{}),
+		nativeAPI:         cnHAProxyClient,
+		activeBackends:    make(map[string]struct{}),
+		permanentBackends: make(map[string]struct{}),
 	}
 	return &cn, nil
 }

pkg/haproxy/api/backend.go

@@ -44,6 +44,35 @@ func (c *clientNative) BackendCreate(backend models.Backend) error {
 	return nil
 }
 
+func (c *clientNative) BackendCreatePermanently(backend models.Backend) error {
+	err := c.BackendCreate(backend)
+	if err != nil {
+		return err
+	}
+	c.permanentBackends[backend.Name] = struct{}{}
+	return nil
+}
+
+func (c *clientNative) BackendCreateIfNotExist(backend models.Backend) (err error) {
+	configuration, err := c.nativeAPI.Configuration()
+	if err != nil {
+		return
+	}
+	c.activeTransactionHasChanges = true
+	defer func() {
+		if err == nil {
+			c.activeBackends[backend.Name] = struct{}{}
+		}
+	}()
+
+	_, _, err = configuration.GetBackend(backend.Name, c.activeTransaction)
+	if err == nil {
+		return
+	}
+
+	return configuration.CreateBackend(&backend, c.activeTransaction, 0)
+}
+
 func (c *clientNative) BackendEdit(backend models.Backend) error {
 	configuration, err := c.nativeAPI.Configuration()
 	if err != nil {
@@ -207,6 +236,9 @@ func (c *clientNative) RefreshBackends() (deleted []string, err error) {
 		return
 	}
 	for _, backend := range backends {
+		if _, ok := c.permanentBackends[backend.Name]; ok {
+			continue
+		}
 		if _, ok := c.activeBackends[backend.Name]; !ok {
 			if err = c.BackendDelete(backend.Name); err != nil {
 				return