TEST/MEDIUM: e2e: Retry upon connection failures

When connection fails in tests we used to run suite.FailNow which makes
the test fails miserably and beating the purpose of suite.Eventually
bloc.
This was fixed in order to keep retrying the tests inside
suite.Eventually even when there is a connection failure

Author: Mo3m3n

deploy/tests/e2e/basic-auth/basic_auth_test.go

@@ -41,7 +41,8 @@ func (suite *HTTPBasicAuthSuite) Test_BasicAuth() {
 				suite.client.Req.SetBasicAuth(user, "password")
 				res, cls, err := suite.client.Do()
 				if err != nil {
-					suite.FailNow(err.Error())
+					suite.T().Logf("Connection ERROR: %s", err.Error())
+					return false
 				}
 				defer cls()
 				return res.StatusCode == http.StatusOK

deploy/tests/e2e/config-snippet/backend_cfg_snippet.go

@@ -28,7 +28,8 @@ func (suite *ConfigSnippetSuite) TestBackendCfgSnippet() {
 	suite.Eventually(func() bool {
 		res, cls, err := suite.client.Do()
 		if err != nil {
-			suite.FailNow(err.Error())
+			suite.T().Logf("Connection ERROR: %s", err.Error())
+			return false
 		}
 		defer cls()
 		b, err := ioutil.ReadAll(res.Body)

deploy/tests/e2e/config-snippet/frontend_cfg_snippet.go

@@ -28,7 +28,8 @@ func (suite *ConfigSnippetSuite) TestFrontendCfgSnippet() {
 	suite.Eventually(func() bool {
 		res, cls, err := suite.client.Do()
 		if err != nil {
-			suite.FailNow(err.Error())
+			suite.T().Logf("Connection ERROR: %s", err.Error())
+			return false
 		}
 		defer cls()
 		b, err := ioutil.ReadAll(res.Body)

deploy/tests/e2e/rate-limiting/http_rate_limiting_test.go

@@ -47,7 +47,8 @@ func (suite *RateLimitingSuite) Test_Rate_Limiting() {
 				for responseCode != tc.customStatusCode {
 					res, cls, err := suite.client.Do()
 					if err != nil {
-						suite.FailNow(err.Error())
+						suite.T().Logf("Connection ERROR: %s", err.Error())
+						return false
 					}
 					defer cls()
 					if res.StatusCode == 200 {

deploy/tests/e2e/set-header/set_header_test.go

@@ -40,7 +40,8 @@ func (suite *SetHeaderSuite) Test_Request_Set_Header() {
 		suite.Eventually(func() bool {
 			res, cls, err := suite.client.Do()
 			if err != nil {
-				suite.FailNow(err.Error())
+				suite.T().Logf("Connection ERROR: %s", err.Error())
+				return false
 			}
 			defer cls()
 			b, err := ioutil.ReadAll(res.Body)

deploy/tests/e2e/set-header/set_host_test.go

@@ -33,7 +33,8 @@ func (suite *SetHeaderSuite) Test_Set_Host() {
 			suite.Eventually(func() bool {
 				res, cls, err := suite.client.Do()
 				if err != nil {
-					suite.FailNow(err.Error())
+					suite.T().Logf("Connection ERROR: %s", err.Error())
+					return false
 				}
 				defer cls()
 				b, err := ioutil.ReadAll(res.Body)

deploy/tests/e2e/source-ip/source_ip_test.go

@@ -43,7 +43,8 @@ func (suite *SourceIPSuite) Test_Set_Source_Ip() {
 				}
 				res, cls, err := suite.client.Do()
 				if err != nil {
-					suite.FailNow(err.Error())
+					suite.T().Logf("Connection ERROR: %s", err.Error())
+					return false
 				}
 				defer cls()
 				return res.StatusCode != http.StatusOK