BUG/MEDIUM: fix runtime socket commands response parsing

hdurand0710 · oktalz · commit 5f8e85f0e4b4 · 2025-04-07T08:32:54.000Z
We were not parsing correctly the response from the runtime command socket, and not detecting correctly the errors.
The consequence was that if a runtime command failed, we were not triggering a reload and that would lead to inconsistencies between the configuration and the runtime
diff --git a/pkg/haproxy/api/runtime.go b/pkg/haproxy/api/runtime.go
@@ -103,7 +103,7 @@ func (c *clientNative) runRaw(runtime runtime.Runtime, sb strings.Builder, backe
 		return err
 	}
 	if len(result) > 5 {
-		switch result[1:5] {
+		switch result[0:4] {
 		case "[3]:", "[2]:", "[1]:", "[0]:":
 			logger.Errorf("[RUNTIME] [BACKEND] [SOCKET] backend %s', server slots adjustment ?", backendName)
 			logger.Tracef("[RUNTIME] [BACKEND] [SOCKET] backend %s: Error: '%s', server slots adjustment ?", backendName, result)

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ func (c *clientNative) runRaw(runtime runtime.Runtime, sb strings.Builder, backe`
`103`	`103`	`return err`
`104`	`104`	`}`
`105`	`105`	`if len(result) > 5 {`
`106`		`- switch result[1:5] {`
	`106`	`+ switch result[0:4] {`
`107`	`107`	`case "[3]:", "[2]:", "[1]:", "[0]:":`
`108`	`108`	`logger.Errorf("[RUNTIME] [BACKEND] [SOCKET] backend %s', server slots adjustment ?", backendName)`
`109`	`109`	`logger.Tracef("[RUNTIME] [BACKEND] [SOCKET] backend %s: Error: '%s', server slots adjustment ?", backendName, result)`