MINOR: use dynamic cookies

When cookie usage is enabled for session persistence the controller will
configure dynamic cookie in the corresponding backend via the
dynamic-cookie-key directive.
This enables session persistence even when using multiple haproxy
instances.

Author: Mo3m3n

controller/annotations/service/cookie.go

@@ -35,6 +35,7 @@ func (a *Cookie) Process(k store.K8s, annotations ...map[string]string) error {
 		Type:     "insert",
 		Nocache:  true,
 		Indirect: true,
+		Dynamic:  true,
 	}
 	return nil
 }

controller/service/service.go

@@ -148,13 +148,22 @@ func (s *SvcContext) HandleBackend(client api.HAProxyClient, store store.K8s) (r
 func (s *SvcContext) getBackendModel(store store.K8s) (*models.Backend, error) {
 	var backend *models.Backend
 	var err error
+	var cookieKey = "ohph7OoGhong"
 	crInuse := true
 	backend, err = annotations.ModelBackend("cr-backend", s.service.Namespace, store, s.service.Annotations, s.ingress.Annotations, store.ConfigMaps.Main.Annotations)
 	logger.Warning(err)
 	if backend == nil {
 		backend = &models.Backend{DefaultServer: &models.DefaultServer{}}
 		crInuse = false
 	}
+	if !crInuse {
+		for _, a := range annotations.Backend(backend, store, s.certs) {
+			err = a.Process(store, s.service.Annotations, s.ingress.Annotations, store.ConfigMaps.Main.Annotations)
+			if err != nil {
+				logger.Errorf("service '%s/%s': annotation '%s': %s", s.service.Namespace, s.service.Name, a.GetName(), err)
+			}
+		}
+	}
 	if s.modeTCP {
 		backend.Mode = "tcp"
 	} else {
@@ -166,14 +175,8 @@ func (s *SvcContext) getBackendModel(store store.K8s) (*models.Backend, error) {
 	if s.service.DNS != "" {
 		backend.DefaultServer = &models.DefaultServer{InitAddr: "last,libc,none"}
 	}
-	if crInuse {
-		return backend, nil
-	}
-	for _, a := range annotations.Backend(backend, store, s.certs) {
-		err = a.Process(store, s.service.Annotations, s.ingress.Annotations, store.ConfigMaps.Main.Annotations)
-		if err != nil {
-			logger.Errorf("service '%s/%s': annotation '%s': %s", s.service.Namespace, s.service.Name, a.GetName(), err)
-		}
+	if backend.Cookie != nil && backend.Cookie.Dynamic && backend.DynamicCookieKey == "" {
+		backend.DynamicCookieKey = cookieKey
 	}
 	return backend, nil
 }

go.mod

@@ -5,8 +5,8 @@ go 1.16
 require (
 	github.com/go-test/deep v1.0.7
 	github.com/google/renameio v1.0.1
-	github.com/haproxytech/client-native/v2 v2.5.1-0.20211004122714-a56b971bedc9
-	github.com/haproxytech/config-parser/v4 v4.0.0-rc1.0.20211004110516-d82fb76fc458
+	github.com/haproxytech/client-native/v2 v2.5.1-0.20211007115328-c277059aa132
+	github.com/haproxytech/config-parser/v4 v4.0.0-rc2.0.20211007114222-853a40685fb7
 	github.com/jessevdk/go-flags v1.4.0
 	github.com/stretchr/testify v1.6.1
 	k8s.io/api v0.21.3

go.sum

@@ -219,10 +219,10 @@ github.com/googleapis/gnostic v0.4.1 h1:DLJCy1n/vrD4HPjOvYcT8aYQXpPIzoRZONaYwyyc
 github.com/googleapis/gnostic v0.4.1/go.mod h1:LRhVm6pbyptWbWbuZ38d1eyptfvIytN3ir6b65WBswg=
 github.com/gorilla/websocket v1.4.2/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
 github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7/go.mod h1:FecbI9+v66THATjSRHfNgh1IVFe/9kFxbXtjV0ctIMA=
-github.com/haproxytech/client-native/v2 v2.5.1-0.20211004122714-a56b971bedc9 h1:U9LbBWz1BW3Pkfq4KggfJlZZa/0XvrUt045Ez5CBKe4=
-github.com/haproxytech/client-native/v2 v2.5.1-0.20211004122714-a56b971bedc9/go.mod h1:gX1omLb7Snhn7czPbbBt7Ucd8rbM39UzM5zN1P/slQY=
-github.com/haproxytech/config-parser/v4 v4.0.0-rc1.0.20211004110516-d82fb76fc458 h1:Hq+lWbjH25PeHZikzcpJWJjyaSv0KLixUZehe/xzYe8=
-github.com/haproxytech/config-parser/v4 v4.0.0-rc1.0.20211004110516-d82fb76fc458/go.mod h1:4gaeOV9SKzre1pApNZF5/hOp8mjCpr7wdUZ8BRg3U/k=
+github.com/haproxytech/client-native/v2 v2.5.1-0.20211007115328-c277059aa132 h1:8lvpPziu4Udk7f0t8rh3DHzDS1CYTIReR5YNsULfzqw=
+github.com/haproxytech/client-native/v2 v2.5.1-0.20211007115328-c277059aa132/go.mod h1:1EpygYWZ9ujhR/O0zYSgww+D9TILAJ0qySwxDTLodQA=
+github.com/haproxytech/config-parser/v4 v4.0.0-rc2.0.20211007114222-853a40685fb7 h1:u2ACwJkXIVa8o340cKoTaA3rBHxQi/gPpR5mzTDscLE=
+github.com/haproxytech/config-parser/v4 v4.0.0-rc2.0.20211007114222-853a40685fb7/go.mod h1:4gaeOV9SKzre1pApNZF5/hOp8mjCpr7wdUZ8BRg3U/k=
 github.com/haproxytech/go-logger v1.0.0 h1:+erE6HEOjOLPogv9rcp1Jm6FojZ6FNPVMxrp9Pm75HI=
 github.com/haproxytech/go-logger v1.0.0/go.mod h1:OekUd8HCb7ubxMplzHUPBTHNxZmddOWfOjWclZsqIeM=
 github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=