BUG: fix rate limiting backend management

This commit introduces the function BackendUsed to determine if a backend is present and used.

Author: ivanmatmati

pkg/haproxy/api/api.go

@@ -37,7 +37,11 @@ type HAProxyClient interface { //nolint:interfacebloat
 	ACLEdit(id int64, parentType string, parentName string, data *models.ACL) error
 	BackendsGet() models.Backends
 	BackendGet(backendName string) (*models.Backend, error)
+	// This function tests if a backend is existing :
+	// Check if you're not rather looking for BackendUsed function.
 	BackendExists(backendName string) bool
+	// This function tests if a backend is existing AND IT'S USED.
+	BackendUsed(backendName string) bool
 	BackendCreatePermanently(backend models.Backend)
 	BackendCreateIfNotExist(backend models.Backend)
 	BackendCreateOrUpdate(backend models.Backend) (map[string][]interface{}, bool)

pkg/haproxy/api/backend.go

@@ -41,7 +41,7 @@ func (c *clientNative) BackendCreateIfNotExist(backend models.Backend) {
 	existingBackend := c.backends[backend.Name]
 	existingBackend.Used = true
 	c.backends[backend.Name] = existingBackend
-	if c.BackendExists(backend.Name) {
+	if c.BackendUsed(backend.Name) {
 		return
 	}
 	c.BackendCreateOrUpdate(backend)
@@ -240,6 +240,8 @@ func (c *clientNative) BackendServersGet(backendName string) (models.Servers, er
 	return servers, nil
 }
 
+// This function tests if a backend is existing
+// Check if you're not rather looking for BackendUsed function.
 func (c *clientNative) BackendExists(backendName string) (exists bool) {
 	_, exists = c.backends[backendName]
 	return
@@ -266,3 +268,12 @@ func (c *clientNative) BackendDeleteAllUnnecessary() ([]string, error) {
 	}
 	return backendDeleted, errs.Result()
 }
+
+// This function tests if a backend is existing AND IT'S USED.
+func (c *clientNative) BackendUsed(backendName string) bool {
+	backend, exists := c.backends[backendName]
+	if !exists {
+		return false
+	}
+	return backend.Used
+}

pkg/haproxy/rules/reqTrack.go

@@ -27,15 +27,17 @@ func (r ReqTrack) Create(client api.HAProxyClient, frontend *models.Frontend, in
 	}
 
 	// Create tracking table.
-	client.BackendCreateOrUpdate(models.Backend{
-		Name: r.TableName,
-		StickTable: &models.ConfigStickTable{
-			Peers: "localinstance",
-			Type:  "ip",
-			Size:  r.TableSize,
-			Store: fmt.Sprintf("http_req_rate(%d)", *r.TablePeriod),
-		},
-	})
+	if !client.BackendUsed(r.TableName) {
+		client.BackendCreateOrUpdate(models.Backend{
+			Name: r.TableName,
+			StickTable: &models.ConfigStickTable{
+				Peers: "localinstance",
+				Type:  "ip",
+				Size:  r.TableSize,
+				Store: fmt.Sprintf("http_req_rate(%d)", *r.TablePeriod),
+			},
+		})
+	}
 	// Create rule
 	httpRule := models.HTTPRequestRule{
 		Index:         utils.PtrInt64(0),