BUG/MEDIUM: Fix inconsistent processing of haproxy files

- Fix uninitialized map access
- handling files (errorfiles and patternfiles) by reference to make
  changes persistent.

Regression introduced in 708775f

Author: Mo3m3n

controller/configuration/main.go

@@ -173,7 +173,7 @@ func (c *ControllerCfg) envInit() (err error) {
 		c.Env.PatternDir = filepath.Join(c.Env.CfgDir, "patterns")
 	}
 	if c.Env.ErrFileDir == "" {
-		c.Env.ErrFileDir = filepath.Join(c.Env.CfgDir, "errors")
+		c.Env.ErrFileDir = filepath.Join(c.Env.CfgDir, "errorfiles")
 	}
 
 	for _, d := range []string{

controller/handler.go

@@ -41,15 +41,15 @@ func (c *HAProxyController) initHandlers() {
 			Port:     c.OSArgs.HTTPSBindPort,
 		},
 		handler.ProxyProtocol{},
-		handler.ErrorFile{},
+		&handler.ErrorFile{},
 		handler.TCPServices{
 			CertDir:  c.Cfg.Env.FrontendCertDir,
 			IPv4:     !c.OSArgs.DisableIPV4,
 			AddrIPv4: c.OSArgs.IPV4BindAddr,
 			IPv6:     !c.OSArgs.DisableIPV6,
 			AddrIPv6: c.OSArgs.IPV6BindAddr,
 		},
-		handler.PatternFiles{},
+		&handler.PatternFiles{},
 		handler.Refresh{},
 	}
 	if c.OSArgs.PprofEnabled {

controller/handler/errorfile.go

@@ -31,7 +31,7 @@ type ErrorFile struct {
 	updateAPI bool
 }
 
-func (h ErrorFile) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAProxyClient) (reload bool, err error) {
+func (h *ErrorFile) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAProxyClient) (reload bool, err error) {
 	h.files.dir = cfg.Env.ErrFileDir
 	if k.ConfigMaps.Errorfiles == nil {
 		return false, nil

controller/handler/pattern-files.go

@@ -30,17 +30,8 @@ type PatternFiles struct {
 	files files
 }
 
-type files struct {
-	dir  string
-	data map[string]file
-}
-type file struct {
-	hash    string
-	inUse   bool
-	updated bool
-}
-
-func (h PatternFiles) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAProxyClient) (reload bool, err error) {
+func (h *PatternFiles) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAProxyClient) (reload bool, err error) {
+	h.files.dir = cfg.Env.PatternDir
 	if k.ConfigMaps.PatternFiles == nil {
 		return false, nil
 	}
@@ -77,23 +68,39 @@ func (h PatternFiles) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAP
 	return reload, nil
 }
 
-func (f files) deleteFile(code string) error {
+type files struct {
+	dir  string
+	data map[string]*file
+}
+
+type file struct {
+	hash    string
+	inUse   bool
+	updated bool
+}
+
+func (f *files) deleteFile(code string) error {
 	delete(f.data, code)
 	err := os.Remove(filepath.Join(f.dir, code))
 	return err
 }
-func (f files) newFile(code, value string) error {
+
+func (f *files) newFile(code, value string) error {
 	if err := renameio.WriteFile(filepath.Join(f.dir, code), []byte(value), os.ModePerm); err != nil {
 		return err
 	}
-	f.data[code] = file{
+	if f.data == nil {
+		f.data = map[string]*file{}
+	}
+	f.data[code] = &file{
 		hash:    utils.Hash([]byte(value)),
 		inUse:   true,
 		updated: true,
 	}
 	return nil
 }
-func (f files) updateFile(name, value string) error {
+
+func (f *files) updateFile(name, value string) error {
 	newHash := utils.Hash([]byte(value))
 	file := f.data[name]
 	if file.hash != newHash {