BUG/MEDIUM: fix runtime socket commands response parsing

hdurand0710 · oktalz · commit d2b47b49800f · 2025-04-07T08:33:10.000Z
We were not parsing correctly the response from the runtime command socket, and not detecting correctly the errors.
The consequence was that if a runtime command failed, we were not triggering a reload and that would lead to inconsistencies between the configuration and the runtime
diff --git a/pkg/haproxy/api/runtime.go b/pkg/haproxy/api/runtime.go
@@ -104,7 +104,7 @@ func (c *clientNative) runRaw(runtime runtime.Runtime, sb strings.Builder, backe
 	}
 	for i := range result {
 		if len(result[i]) > 5 {
-			switch result[i][1:5] {
+			switch result[i][0:4] {
 			case "[3]:", "[2]:", "[1]:", "[0]:":
 				logger.Errorf("[RUNTIME] [BACKEND] [SOCKET] backend %s', server slots adjustment ?", backendName)
 				logger.Tracef("[RUNTIME] [BACKEND] [SOCKET] backend %s: Error: '%s', server slots adjustment ?", backendName, result[i])

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (c *clientNative) runRaw(runtime runtime.Runtime, sb strings.Builder, backe`
`104`	`104`	`}`
`105`	`105`	`for i := range result {`
`106`	`106`	`if len(result[i]) > 5 {`
`107`		`- switch result[i][1:5] {`
	`107`	`+ switch result[i][0:4] {`
`108`	`108`	`case "[3]:", "[2]:", "[1]:", "[0]:":`
`109`	`109`	`logger.Errorf("[RUNTIME] [BACKEND] [SOCKET] backend %s', server slots adjustment ?", backendName)`
`110`	`110`	`logger.Tracef("[RUNTIME] [BACKEND] [SOCKET] backend %s: Error: '%s', server slots adjustment ?", backendName, result[i])`