BUILD: debug: mark ha_crash_now() as attribute(noreturn)

wtarreau · wtarreau · commit 0a91c6dcaebd · 2025-05-16T16:43:53.000+02:00
Building on MIPS64 with clang16 incorrectly reports some uninitialized
value warnings in stats-proxy.c due to some calls to ABORT_NOW() where
the compiler didn't know the code wouldn't return. Let's properly mark
the function as noreturn, and take this opportunity for also marking it
unused to avoid possible warnings depending on the build options (if
ABORT_NOW is not used). No backport needed though it will not harm.
diff --git a/include/haproxy/bug.h b/include/haproxy/bug.h
@@ -68,7 +68,7 @@
 #else // not x86
 
 /* generic implementation, causes a segfault */
-static inline __attribute((always_inline)) void ha_crash_now(void)
+static inline __attribute((always_inline,noreturn,unused)) void ha_crash_now(void)
 {
 #if __GNUC_PREREQ__(5, 0)
 #pragma GCC diagnostic push

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@`
`68`	`68`	`#else // not x86`
`69`	`69`
`70`	`70`	`/* generic implementation, causes a segfault */`
`71`		`-static inline __attribute((always_inline)) void ha_crash_now(void)`
	`71`	`+static inline __attribute((always_inline,noreturn,unused)) void ha_crash_now(void)`
`72`	`72`	`{`
`73`	`73`	`#if __GNUC_PREREQ__(5, 0)`
`74`	`74`	`#pragma GCC diagnostic push`