MINOR: quic: Help diagnosing malformed probing packets

haproxyFred · haproxyFred · commit 11891e1ce489 · 2024-11-04T17:55:38.000+01:00
Add a BUG_ON() to detect some malformed packets which are supposed to probe the
peer without being ack-eliciting: the peer would not acknowledged such packets.
diff --git a/src/quic_tx.c b/src/quic_tx.c
@@ -2071,6 +2071,8 @@ static int qc_do_build_pkt(unsigned char *pos, const unsigned char *end,
 		goto no_room;
 	}
 
+	BUG_ON(qel->pktns->tx.pto_probe &&
+	       !(pkt->flags & QUIC_FL_TX_PACKET_ACK_ELICITING));
 	/* If this packet is ack-eliciting and we are probing let's
 	 * decrement the PTO probe counter.
 	 */

Original file line number	Diff line number	Diff line change
`@@ -2071,6 +2071,8 @@ static int qc_do_build_pkt(unsigned char pos, const unsigned char end,`
`2071`	`2071`	`goto no_room;`
`2072`	`2072`	`}`
`2073`	`2073`
	`2074`	`+ BUG_ON(qel->pktns->tx.pto_probe &&`
	`2075`	`+ !(pkt->flags & QUIC_FL_TX_PACKET_ACK_ELICITING));`
`2074`	`2076`	`/* If this packet is ack-eliciting and we are probing let's`
`2075`	`2077`	`* decrement the PTO probe counter.`
`2076`	`2078`	`*/`