Skip to content

Commit 16147e6

Browse files
committed
BUG/MINOR: cfgparse-quic: fix renaming of max-window-size
A patch has recently tried to rename QUIC max-window-size global parameter to default-max-window-size to better reflect its usage. However, only the documentation was edited but not cfgparse-quic.c. Fix this by updating cfgparse-quic.c with the new default- naming. No need to backport.
1 parent 17d4e6e commit 16147e6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/cfgparse-quic.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,14 +347,14 @@ static int cfg_parse_quic_tune_setting(char **args, int section_type,
347347
global.tune.quic_cubic_loss_tol = arg - 1;
348348
else if (strcmp(suffix, "frontend.conn-tx-buffers.limit") == 0) {
349349
memprintf(err, "'%s' keyword is now obsolote and has no effect. "
350-
"Use 'tune.quic.frontend.max-window-size' to limit Tx buffer allocation per connection.", args[0]);
350+
"Use 'tune.quic.frontend.default-max-window-size' to limit Tx buffer allocation per connection.", args[0]);
351351
return 1;
352352
}
353353
else if (strcmp(suffix, "frontend.glitches-threshold") == 0)
354354
global.tune.quic_frontend_glitches_threshold = arg;
355355
else if (strcmp(suffix, "frontend.max-streams-bidi") == 0)
356356
global.tune.quic_frontend_max_streams_bidi = arg;
357-
else if (strcmp(suffix, "frontend.max-window-size") == 0) {
357+
else if (strcmp(suffix, "frontend.default-max-window-size") == 0) {
358358
unsigned long cwnd;
359359
char *end_opt;
360360

@@ -457,7 +457,7 @@ static struct cfg_kw_list cfg_kws = {ILH, {
457457
{ CFG_GLOBAL, "tune.quic.frontend.glitches-threshold", cfg_parse_quic_tune_setting },
458458
{ CFG_GLOBAL, "tune.quic.frontend.max-streams-bidi", cfg_parse_quic_tune_setting },
459459
{ CFG_GLOBAL, "tune.quic.frontend.max-idle-timeout", cfg_parse_quic_time },
460-
{ CFG_GLOBAL, "tune.quic.frontend.max-window-size", cfg_parse_quic_tune_setting },
460+
{ CFG_GLOBAL, "tune.quic.frontend.default-max-window-size", cfg_parse_quic_tune_setting },
461461
{ CFG_GLOBAL, "tune.quic.max-frame-loss", cfg_parse_quic_tune_setting },
462462
{ CFG_GLOBAL, "tune.quic.reorder-ratio", cfg_parse_quic_tune_setting },
463463
{ CFG_GLOBAL, "tune.quic.retry-threshold", cfg_parse_quic_tune_setting },

0 commit comments

Comments
 (0)