MINOR: quic: extend return value of CRYPTO parsing

Author: a-denoyelle

src/quic_rx.c

@@ -616,16 +616,20 @@ static int qc_handle_strm_frm(struct quic_rx_packet *pkt,
 	return !ret;
 }
 
-/* Parse <frm> CRYPTO frame coming with <pkt> packet at <qel> <qc> connectionn.
- * Returns 1 if succeeded, 0 if not. Also set <*fast_retrans> to 1 if the
- * speed up handshake completion may be run after having received duplicated
- * CRYPTO data.
+/* Parse <frm> CRYPTO frame coming with <pkt> packet at <qel> <qc> connection.
+ *
+ * Returns 0 on success or a negative error code. A positive value is used to
+ * indicate that the current frame cannot be handled immediately, but it could
+ * be solved by running a new packet parsing iteration.
+ *
+ * Also set <*fast_retrans> as output parameter to 1 if the speed up handshake
+ * completion may be run after having received duplicated CRYPTO data.
  */
 static int qc_handle_crypto_frm(struct quic_conn *qc,
                                 struct qf_crypto *crypto_frm, struct quic_rx_packet *pkt,
                                 struct quic_enc_level *qel, int *fast_retrans)
 {
-	int ret = 0;
+	int ret = -1;
 	enum ncb_ret ncb_ret;
 	/* XXX TO DO: <cfdebug> is used only for the traces. */
 	struct quic_rx_crypto_frm cfdebug = {
@@ -676,6 +680,7 @@ static int qc_handle_crypto_frm(struct quic_conn *qc,
 		else if (ncb_ret == NCB_RET_GAP_SIZE) {
 			TRACE_ERROR("cannot bufferize frame due to gap size limit",
 			            QUIC_EV_CONN_PRSHPKT, qc);
+			ret = 1;
 		}
 		goto leave;
 	}
@@ -687,7 +692,7 @@ static int qc_handle_crypto_frm(struct quic_conn *qc,
 	}
 
  done:
-	ret = 1;
+	ret = 0;
  leave:
 	TRACE_LEAVE(QUIC_EV_CONN_PRSHPKT, qc);
 	return ret;
@@ -770,7 +775,7 @@ static int qc_parse_pkt_frms(struct quic_conn *qc, struct quic_rx_packet *pkt,
 {
 	struct quic_frame frm;
 	const unsigned char *pos, *end;
-	int fast_retrans = 0;
+	int fast_retrans = 0, ret = 0;
 
 	TRACE_ENTER(QUIC_EV_CONN_PRSHPKT, qc);
 	/* Skip the AAD */
@@ -843,9 +848,12 @@ static int qc_parse_pkt_frms(struct quic_conn *qc, struct quic_rx_packet *pkt,
 			break;
 		}
 		case QUIC_FT_CRYPTO:
-			if (!qc_handle_crypto_frm(qc, &frm.crypto, pkt, qel, &fast_retrans))
+		{
+			ret = qc_handle_crypto_frm(qc, &frm.crypto, pkt, qel, &fast_retrans);
+			if (ret != 0)
 				goto err;
 			break;
+		}
 		case QUIC_FT_NEW_TOKEN:
 			/* TODO */
 			break;