MINOR: debug: make mark_tainted() return the previous value

wtarreau · wtarreau · commit 8e048603d1bb · 2024-10-19T15:13:47.000+02:00
Since mark_tainted() uses atomic ops to update the tainted status, let's
make it return the prior value, which will allow the caller to detect
if it's the first one to set it or not.
diff --git a/include/haproxy/bug.h b/include/haproxy/bug.h
@@ -337,9 +337,9 @@ extern unsigned int tainted;
 
 void complain(int *counter, const char *msg, int taint);
 
-static inline void mark_tainted(const enum tainted_flags flag)
+static inline unsigned int mark_tainted(const enum tainted_flags flag)
 {
-	HA_ATOMIC_OR(&tainted, flag);
+	return HA_ATOMIC_FETCH_OR(&tainted, flag);
 }
 
 static inline unsigned int get_tainted()

Original file line number	Diff line number	Diff line change
`@@ -337,9 +337,9 @@ extern unsigned int tainted;`
`337`	`337`
`338`	`338`	`void complain(int counter, const char msg, int taint);`
`339`	`339`
`340`		`-static inline void mark_tainted(const enum tainted_flags flag)`
	`340`	`+static inline unsigned int mark_tainted(const enum tainted_flags flag)`
`341`	`341`	`{`
`342`		`- HA_ATOMIC_OR(&tainted, flag);`
	`342`	`+ return HA_ATOMIC_FETCH_OR(&tainted, flag);`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`static inline unsigned int get_tainted()`