Skip to content

Commit bc8e454

Browse files
committed
MINOR: quic: Add useful error traces about qc_ssl_sess_init() failures
There were no traces to diagnose qc_ssl_sess_init() failures from QUIC traces. This patch add calls to TRACE_DEVEL() into qc_ssl_sess_init() and its caller (qc_alloc_ssl_sock_ctx()). This was useful at least to diagnose SSL context initialization failures when porting QUIC to the new OpenSSL 3.5 QUIC API. Should be easily backported as far as 2.6.
1 parent 5ec2375 commit bc8e454

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/quic_ssl.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
752752
*ssl = SSL_new(ssl_ctx);
753753
if (!*ssl) {
754754
if (!retry--)
755-
goto leave;
755+
goto err;
756756

757757
pool_gc(NULL);
758758
goto retry;
@@ -763,7 +763,7 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
763763
SSL_free(*ssl);
764764
*ssl = NULL;
765765
if (!retry--)
766-
goto leave;
766+
goto err;
767767

768768
pool_gc(NULL);
769769
goto retry;
@@ -773,6 +773,9 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
773773
leave:
774774
TRACE_LEAVE(QUIC_EV_CONN_NEW, qc);
775775
return ret;
776+
err:
777+
TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW, qc);
778+
goto leave;
776779
}
777780

778781
#ifdef HAVE_SSL_0RTT_QUIC
@@ -870,6 +873,7 @@ int qc_alloc_ssl_sock_ctx(struct quic_conn *qc)
870873
return !ret;
871874

872875
err:
876+
TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW, qc);
873877
pool_free(pool_head_quic_ssl_sock_ctx, ctx);
874878
goto leave;
875879
}

0 commit comments

Comments
 (0)