BUG/MINOR: errors: startup_logs_free: set global startup_logs ptr to NULL

einval22 · wlallemand · commit bf8c871e26c2 · 2024-10-29T18:17:49.000+01:00
ring_free() calls free() on the ring struct pointer, but startup_logs continues
to keep this address. So let's reset at the end startup_logs to NULL.
startup_logs is checked in print_message().

No need to backport this fix, as it's related to the latest master-worker
refactoring.
diff --git a/src/errors.c b/src/errors.c
@@ -150,6 +150,7 @@ void startup_logs_free(struct ring *r)
 		munmap(ring_allocated_area(r), STARTUP_LOG_SIZE);
 #endif /* ! USE_SHM_OPEN */
 	ring_free(r);
+	startup_logs = NULL;
 }
 
 /* duplicate a startup logs which was previously allocated in a shm */

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,7 @@ void startup_logs_free(struct ring *r)`
`150`	`150`	`munmap(ring_allocated_area(r), STARTUP_LOG_SIZE);`
`151`	`151`	`#endif /* ! USE_SHM_OPEN */`
`152`	`152`	`ring_free(r);`
	`153`	`+ startup_logs = NULL;`
`153`	`154`	`}`
`154`	`155`
`155`	`156`	`/* duplicate a startup logs which was previously allocated in a shm */`