BUG/MINOR: startup: dump libs only in worker if started with -W -dL

einval22 · einval22 · commit ea824aebc1ac · 2024-10-30T10:00:40.000+01:00
If haproxy was started with -W -dL, after master-worker refactoring we dump
libs to stdout twice in master and in worker processes. This is information is
redundant. So let's show linked libraries only in the worker context, if
haproxy was started also with -W.

This does not need to be backported, as related to the latest master-worker
rework.
diff --git a/src/haproxy.c b/src/haproxy.c
@@ -2456,7 +2456,7 @@ static void step_init_2(int argc, char** argv)
 	}
 
 #if defined(HA_HAVE_DUMP_LIBS)
-	if (global.mode & MODE_DUMP_LIBS) {
+	if (global.mode & MODE_DUMP_LIBS && !master) {
 		qfprintf(stdout, "List of loaded object files:\n");
 		chunk_reset(&trash);
 		if (dump_libs(&trash, ((arg_mode & (MODE_QUIET|MODE_VERBOSE)) == MODE_VERBOSE)))

Original file line number	Diff line number	Diff line change
`@@ -2456,7 +2456,7 @@ static void step_init_2(int argc, char** argv)`
`2456`	`2456`	`}`
`2457`	`2457`
`2458`	`2458`	`#if defined(HA_HAVE_DUMP_LIBS)`
`2459`		`- if (global.mode & MODE_DUMP_LIBS) {`
	`2459`	`+ if (global.mode & MODE_DUMP_LIBS && !master) {`
`2460`	`2460`	`qfprintf(stdout, "List of loaded object files:\n");`
`2461`	`2461`	`chunk_reset(&trash);`
`2462`	`2462`	`if (dump_libs(&trash, ((arg_mode & (MODE_QUIET\|MODE_VERBOSE)) == MODE_VERBOSE)))`