Fix clippy (asny#547)

* Fix clippy

* Add clippy to CI

Author: asny

.github/workflows/rust.yml

@@ -12,17 +12,19 @@ on:
 env:
   CARGO_TERM_COLOR: always
   RUST_BACKTRACE: 1
+  RUSTFLAGS: "-Dwarnings"
 
 jobs:
   desktop:
+    name: Check Desktop
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         rust: [stable]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install Rust Toolchain
         uses: actions-rs/toolchain@v1
@@ -41,16 +43,22 @@ jobs:
           command: check
           args: --examples --all-features
 
-      - name: Rustfmt
+      - name: Formatting
         uses: actions-rs/cargo@v1
         with:
           command: fmt
-          args: -- --check
+          args: --all -- --check
+
+      - name: Clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
 
   web:
+    name: Check Web
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install Rust Toolchain
         uses: actions-rs/toolchain@v1

examples/headless/src/main.rs

@@ -62,9 +62,7 @@ fn main() {
     // Render three frames
     for frame_index in 0..3 {
         // Set the current transformation of the triangle
-        model.set_transformation(Mat4::from_angle_y(radians(
-            (frame_index as f32 * 0.6) as f32,
-        )));
+        model.set_transformation(Mat4::from_angle_y(radians(frame_index as f32 * 0.6)));
 
         // Create a render target (a combination of a color and a depth texture) to write into
         let pixels = RenderTarget::new(

examples/lighting/src/main.rs

@@ -167,12 +167,10 @@ pub async fn run() {
                     ui.add(Slider::new(&mut spot0.intensity, 0.0..=10.0).text("Spot intensity"));
                     ui.add(Slider::new(&mut point0.intensity, 0.0..=1.0).text("Point 0 intensity"));
                     ui.add(Slider::new(&mut point1.intensity, 0.0..=1.0).text("Point 1 intensity"));
-                    if ui.checkbox(&mut shadows_enabled, "Shadows").clicked() {
-                        if !shadows_enabled {
-                            spot0.clear_shadow_map();
-                            directional0.clear_shadow_map();
-                            directional1.clear_shadow_map();
-                        }
+                    if ui.checkbox(&mut shadows_enabled, "Shadows").clicked() && !shadows_enabled {
+                        spot0.clear_shadow_map();
+                        directional0.clear_shadow_map();
+                        directional1.clear_shadow_map();
                     }
 
                     ui.label("Lighting model");

examples/lights/src/main.rs

@@ -154,7 +154,7 @@ impl Glow {
         );
         Self {
             aabb,
-            light: PointLight::new(&context, 1.0, Srgba::WHITE, pos, Attenuation::default()),
+            light: PointLight::new(context, 1.0, Srgba::WHITE, pos, Attenuation::default()),
             velocity: vec3(
                 rng.gen::<f32>() * 2.0 - 1.0,
                 rng.gen::<f32>() * 2.0 - 1.0,

examples/logo/src/main.rs

@@ -85,7 +85,7 @@ impl Material for LogoMaterial<'_> {
     }
 
     fn use_uniforms(&self, program: &Program, _viewer: &dyn Viewer, _lights: &[&dyn Light]) {
-        program.use_texture("image", &self.image);
+        program.use_texture("image", self.image);
     }
 
     fn render_states(&self) -> RenderStates {

examples/shapes2d/src/main.rs

@@ -77,7 +77,7 @@ pub fn main() {
             .screen()
             .clear(ClearState::color_and_depth(0.8, 0.8, 0.8, 1.0, 1.0))
             .render(
-                &Camera::new_2d(frame_input.viewport),
+                Camera::new_2d(frame_input.viewport),
                 line.into_iter().chain(&rectangle).chain(&circle),
                 &[],
             );

examples/text/src/main.rs

@@ -78,7 +78,7 @@ pub fn main() {
         frame_input
             .screen()
             .clear(ClearState::color_and_depth(1.0, 1.0, 1.0, 1.0, 1.0))
-            .render(&camera, &[&text0, &text1, &text2], &[]);
+            .render(&camera, [&text0, &text1, &text2], &[]);
         FrameOutput::default()
     });
 }

src/core.rs

@@ -99,12 +99,7 @@ pub(crate) fn full_screen_vertex_shader_source() -> &'static str {
 mod data_type;
 use data_type::DataType;
 fn to_byte_slice<T: DataType>(data: &[T]) -> &[u8] {
-    unsafe {
-        std::slice::from_raw_parts(
-            data.as_ptr() as *const _,
-            data.len() * std::mem::size_of::<T>(),
-        )
-    }
+    unsafe { std::slice::from_raw_parts(data.as_ptr() as *const _, std::mem::size_of_val(data)) }
 }
 
 fn from_byte_slice<T: DataType>(data: &[u8]) -> &[T] {

src/core/buffer.rs

@@ -94,7 +94,7 @@ impl<T: BufferDataType> Buffer<T> {
             );
             self.context.bind_buffer(crate::context::ARRAY_BUFFER, None);
         }
-        self.attribute_count = (offset as u32 + data.len() as u32).max(self.attribute_count);
+        self.attribute_count = (offset + data.len() as u32).max(self.attribute_count);
     }
 
     pub fn attribute_count(&self) -> u32 {

src/core/buffer/element_buffer.rs

@@ -95,7 +95,7 @@ impl<T: ElementBufferDataType> ElementBuffer<T> {
             self.context
                 .bind_buffer(crate::context::ELEMENT_ARRAY_BUFFER, None);
         }
-        self.count = (offset as u32 + indices.len() as u32).max(self.count);
+        self.count = (offset + indices.len() as u32).max(self.count);
     }
 
     ///