Skip to content

Commit 28a85a5

Browse files
committed
usb2can wasn't using bitrate. Also had multiple loggers
1 parent e92c5e3 commit 28a85a5

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

can/interfaces/usb2canInterface.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
import logging
44

5-
logger = logging.getLogger('can.usb2can')
6-
7-
85
from can.bus import BusABC
96
from can.message import Message
107
from can.interfaces.usb2can import *
@@ -93,21 +90,17 @@ def __init__(self, channel, *args, **kwargs):
9390

9491
# code to get the serial number of the device
9592
if 'serial' in kwargs:
96-
9793
deviceID = kwargs["serial"]
98-
9994
else:
10095
deviceID = serial()
10196

102-
# set baudrate
103-
if 'baud' in kwargs:
104-
105-
br = kwargs["baud"]
97+
# set baudrate in kb/s from bitrate
98+
# (eg:500000 bitrate must be 500)
99+
if 'bitrate' in kwargs:
100+
br = kwargs["bitrate"]
106101

107-
# set custom baud rate (ex:500000 bitrate must be 500)
108102
# max rate is 1000 kbps
109-
baudrate = int(br)
110-
103+
baudrate = max(1000, int(br/1000))
111104
# set default value
112105
else:
113106
baudrate = 500
@@ -136,7 +129,7 @@ def recv(self, timeout=None):
136129
if status is 0:
137130
rx = message_convert_rx(messagerx)
138131
else:
139-
logger.error('Canal Error %s', status)
132+
log.error('Canal Error %s', status)
140133
rx = None
141134

142135
return rx

0 commit comments

Comments
 (0)