Skip to content

Commit 54d2718

Browse files
authored
set Message.channel in PcanBus.recv (#1969)
1 parent 963bbee commit 54d2718

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

can/interfaces/pcan/pcan.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,7 @@ def _recv_internal(
590590
)
591591

592592
rx_msg = Message(
593+
channel=self.channel_info,
593594
timestamp=timestamp,
594595
arbitration_id=pcan_msg.ID,
595596
is_extended_id=is_extended_id,

doc/changelog.d/1969.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
PcanBus: Set `Message.channel` attribute in `PcanBus.recv()`.

test/test_pcan.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ def test_recv(self):
232232
self.assertEqual(recv_msg.is_fd, False)
233233
self.assertSequenceEqual(recv_msg.data, msg.DATA)
234234
self.assertEqual(recv_msg.timestamp, 0)
235+
self.assertEqual(recv_msg.channel, "PCAN_USBBUS1")
235236

236237
def test_recv_fd(self):
237238
data = (ctypes.c_ubyte * 64)(*[x for x in range(64)])
@@ -255,6 +256,7 @@ def test_recv_fd(self):
255256
self.assertEqual(recv_msg.is_fd, True)
256257
self.assertSequenceEqual(recv_msg.data, msg.DATA)
257258
self.assertEqual(recv_msg.timestamp, 0)
259+
self.assertEqual(recv_msg.channel, "PCAN_USBBUS1")
258260

259261
@pytest.mark.timeout(3.0)
260262
@patch("select.select", return_value=([], [], []))

0 commit comments

Comments
 (0)