Skip to content

Commit 642e711

Browse files
committed
Rename CANProtocol to CanProtocol
1 parent 56e40d2 commit 642e711

File tree

9 files changed

+25
-25
lines changed

9 files changed

+25
-25
lines changed

can/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from .util import set_logging_level
2828

2929
from .message import Message
30-
from .bus import BusABC, BusState, CANProtocol
30+
from .bus import BusABC, BusState, CanProtocol
3131
from .thread_safe_bus import ThreadSafeBus
3232
from .notifier import Notifier
3333
from .interfaces import VALID_INTERFACES

can/bus.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class BusState(Enum):
2727
ERROR = auto()
2828

2929

30-
class CANProtocol(Enum):
30+
class CanProtocol(Enum):
3131
"""The CAN protocol type supported by a :class:`can.BusABC` instance"""
3232

3333
CAN_20 = auto()
@@ -56,7 +56,7 @@ class BusABC(metaclass=ABCMeta):
5656
def __init__(
5757
self,
5858
channel: Any,
59-
protocol: CANProtocol = CANProtocol.CAN_20,
59+
protocol: CanProtocol = CanProtocol.CAN_20,
6060
can_filters: Optional[can.typechecking.CanFilters] = None,
6161
**kwargs: object
6262
):
@@ -460,7 +460,7 @@ def state(self, new_state: BusState) -> None:
460460
raise NotImplementedError("Property is not implemented.")
461461

462462
@property
463-
def protocol(self) -> CANProtocol:
463+
def protocol(self) -> CanProtocol:
464464
"""Return the CAN protocol used by this bus instance.
465465
466466
This value is set at initialization time and does not change

can/interfaces/canalystii.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import canalystii as driver
88

9-
from can import BitTiming, BusABC, Message, BitTimingFd, CANProtocol
9+
from can import BitTiming, BusABC, Message, BitTimingFd, CanProtocol
1010
from can.exceptions import CanTimeoutError
1111
from can.typechecking import CanFilters
1212
from can.util import deprecated_args_alias, check_or_adjust_timing_clock
@@ -53,7 +53,7 @@ def __init__(
5353
super().__init__(
5454
channel=channel,
5555
can_filters=can_filters,
56-
protocol=CANProtocol.CAN_20,
56+
protocol=CanProtocol.CAN_20,
5757
**kwargs,
5858
)
5959

can/interfaces/pcan/pcan.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from can import (
1313
BusABC,
1414
BusState,
15-
CANProtocol,
15+
CanProtocol,
1616
BitTiming,
1717
BitTimingFd,
1818
Message,
@@ -341,7 +341,7 @@ def __init__(
341341

342342
super().__init__(
343343
channel=channel,
344-
protocol=CANProtocol.CAN_FD if is_fd else CANProtocol.CAN_20,
344+
protocol=CanProtocol.CAN_FD if is_fd else CanProtocol.CAN_20,
345345
state=state,
346346
bitrate=bitrate,
347347
**kwargs,
@@ -491,7 +491,7 @@ def _recv_internal(
491491
end_time = time.time() + timeout if timeout is not None else None
492492

493493
while True:
494-
if self.protocol == CANProtocol.CAN_FD:
494+
if self.protocol == CanProtocol.CAN_FD:
495495
result, pcan_msg, pcan_timestamp = self.m_objPCANBasic.ReadFD(
496496
self.m_PcanHandle
497497
)
@@ -553,7 +553,7 @@ def _recv_internal(
553553
error_state_indicator = bool(pcan_msg.MSGTYPE & PCAN_MESSAGE_ESI.value)
554554
is_error_frame = bool(pcan_msg.MSGTYPE & PCAN_MESSAGE_ERRFRAME.value)
555555

556-
if self.protocol == CANProtocol.CAN_FD:
556+
if self.protocol == CanProtocol.CAN_FD:
557557
dlc = dlc2len(pcan_msg.DLC)
558558
timestamp = boottimeEpoch + (pcan_timestamp.value / (1000.0 * 1000.0))
559559
else:
@@ -599,7 +599,7 @@ def send(self, msg, timeout=None):
599599
if msg.error_state_indicator:
600600
msgType |= PCAN_MESSAGE_ESI.value
601601

602-
if self.protocol == CANProtocol.CAN_FD:
602+
if self.protocol == CanProtocol.CAN_FD:
603603
# create a TPCANMsg message structure
604604
CANMsg = TPCANMsgFD()
605605

can/interfaces/slcan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import time
88
from typing import Any, Optional, Tuple
99

10-
from can import BusABC, Message, CANProtocol
10+
from can import BusABC, Message, CanProtocol
1111
from can import typechecking
1212
from ..exceptions import (
1313
CanInterfaceNotImplementedError,
@@ -122,7 +122,7 @@ def __init__(
122122
ttyBaudrate=115200,
123123
bitrate=None,
124124
rtscts=False,
125-
protocol=CANProtocol.CAN_20,
125+
protocol=CanProtocol.CAN_20,
126126
**kwargs,
127127
)
128128

can/interfaces/udp_multicast/bus.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from typing import List, Optional, Tuple, Union
77

88
import can
9-
from can import BusABC, CANProtocol
9+
from can import BusABC, CanProtocol
1010
from can.typechecking import AutoDetectedConfig
1111
from .utils import pack_message, unpack_message, check_msgpack_installed
1212

@@ -103,7 +103,7 @@ def __init__(
103103
)
104104

105105
super().__init__(
106-
channel, **kwargs, protocol=CANProtocol.CAN_FD if fd else CANProtocol.CAN_20
106+
channel, **kwargs, protocol=CanProtocol.CAN_FD if fd else CanProtocol.CAN_20
107107
)
108108

109109
self.is_fd = fd

can/interfaces/virtual.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from random import randint
1717

1818
from can import CanOperationError
19-
from can.bus import BusABC, CANProtocol
19+
from can.bus import BusABC, CanProtocol
2020
from can.message import Message
2121
from can.typechecking import AutoDetectedConfig
2222

@@ -63,7 +63,7 @@ def __init__(
6363
receive_own_messages: bool = False,
6464
rx_queue_size: int = 0,
6565
preserve_timestamps: bool = False,
66-
protocol: CANProtocol = CANProtocol.CAN_20,
66+
protocol: CanProtocol = CanProtocol.CAN_20,
6767
**kwargs: Any,
6868
) -> None:
6969
"""

test/test_interface_canalystii.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_initialize_from_constructor(self):
2323
instance = mock_device.return_value
2424
bus = CANalystIIBus(bitrate=1000000)
2525

26-
self.assertEqual(bus.protocol, can.CANProtocol.CAN_20)
26+
self.assertEqual(bus.protocol, can.CanProtocol.CAN_20)
2727

2828
instance.init.assert_has_calls(
2929
[
@@ -38,7 +38,7 @@ def test_initialize_single_channel_only(self):
3838
instance = mock_device.return_value
3939
bus = CANalystIIBus(channel, bitrate=1000000)
4040

41-
self.assertEqual(bus.protocol, can.CANProtocol.CAN_20)
41+
self.assertEqual(bus.protocol, can.CanProtocol.CAN_20)
4242
instance.init.assert_called_once_with(channel, bitrate=1000000)
4343

4444
def test_initialize_with_timing_registers(self):
@@ -48,7 +48,7 @@ def test_initialize_with_timing_registers(self):
4848
f_clock=8_000_000, btr0=0x03, btr1=0x6F
4949
)
5050
bus = CANalystIIBus(bitrate=None, timing=timing)
51-
self.assertEqual(bus.protocol, can.CANProtocol.CAN_20)
51+
self.assertEqual(bus.protocol, can.CanProtocol.CAN_20)
5252

5353
instance.init.assert_has_calls(
5454
[

test/test_pcan.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from parameterized import parameterized
1212

1313
import can
14-
from can import BusState, CANProtocol
14+
from can import BusState, CanProtocol
1515
from can.exceptions import CanInitializationError
1616
from can.interfaces.pcan import PcanBus, PcanError
1717
from can.interfaces.pcan.basic import *
@@ -53,7 +53,7 @@ def test_bus_creation(self) -> None:
5353
self.bus = can.Bus(interface="pcan")
5454

5555
self.assertIsInstance(self.bus, PcanBus)
56-
self.assertEqual(self.bus.protocol, CANProtocol.CAN_20)
56+
self.assertEqual(self.bus.protocol, CanProtocol.CAN_20)
5757

5858
self.MockPCANBasic.assert_called_once()
5959
self.mock_pcan.Initialize.assert_called_once()
@@ -81,7 +81,7 @@ def test_bus_creation_fd(self, clock_param: str, clock_val: int) -> None:
8181
)
8282

8383
self.assertIsInstance(self.bus, PcanBus)
84-
self.assertEqual(self.bus.protocol, CANProtocol.CAN_FD)
84+
self.assertEqual(self.bus.protocol, CanProtocol.CAN_FD)
8585

8686
self.MockPCANBasic.assert_called_once()
8787
self.mock_pcan.Initialize.assert_not_called()
@@ -459,7 +459,7 @@ def test_constructor_bit_timing(self):
459459

460460
bitrate_arg = self.mock_pcan.Initialize.call_args[0][1]
461461
self.assertEqual(bitrate_arg.value, 0x472F)
462-
self.assertEqual(bus.protocol, CANProtocol.CAN_20)
462+
self.assertEqual(bus.protocol, CanProtocol.CAN_20)
463463

464464
def test_constructor_bit_timing_fd(self):
465465
timing = can.BitTimingFd(
@@ -474,7 +474,7 @@ def test_constructor_bit_timing_fd(self):
474474
data_sjw=1,
475475
)
476476
bus = can.Bus(interface="pcan", channel="PCAN_USBBUS1", timing=timing)
477-
self.assertEqual(bus.protocol, CANProtocol.CAN_FD)
477+
self.assertEqual(bus.protocol, CanProtocol.CAN_FD)
478478

479479
bitrate_arg = self.mock_pcan.InitializeFD.call_args[0][-1]
480480

0 commit comments

Comments
 (0)