Calling stop_all_periodic_tasks() in BusABC (#1174)

Currently, only socketcan is calling stop_all_periodic_tasks() on shutdown and respecting the fact that periodic tasks should be stopped on Bus instance shutdown (according to BusABC.send_periodic docstring).

Author: pierreluctg

can/bus.py

@@ -411,6 +411,7 @@ def shutdown(self) -> None:
         Called to carry out any interface specific cleanup required
         in shutting down a bus.
         """
+        self.stop_all_periodic_tasks()
 
     def __enter__(self):
         return self

can/interfaces/canalystii.py

@@ -204,6 +204,7 @@ def flush_tx_buffer(self, channel: Optional[int] = None) -> None:
                 self.device.flush_tx_buffer(ch, float("infinity"))
 
     def shutdown(self) -> None:
+        super().shutdown()
         for channel in self.channels:
             self.device.stop(channel)
         self.device = None

can/interfaces/cantact.py

@@ -131,6 +131,7 @@ def send(self, msg, timeout=None):
             )
 
     def shutdown(self):
+        super().shutdown()
         with error_check("Cannot shutdown interface"):
             self.interface.stop()
 

can/interfaces/gs_usb.py

@@ -112,4 +112,5 @@ def _recv_internal(
         return msg, False
 
     def shutdown(self):
+        super().shutdown()
         self.gs_usb.stop()

can/interfaces/iscan.py

@@ -152,6 +152,7 @@ def send(self, msg: Message, timeout: Optional[float] = None) -> None:
         iscan.isCAN_TransmitMessageEx(self.channel, ctypes.byref(raw_msg))
 
     def shutdown(self) -> None:
+        super().shutdown()
         iscan.isCAN_CloseDevice(self.channel)
 
 

can/interfaces/kvaser/canlib.py

@@ -643,6 +643,7 @@ def flash(self, flash=True):
             log.error("Could not flash LEDs (%s)", e)
 
     def shutdown(self):
+        super().shutdown()
         # Wait for transmit queue to be cleared
         try:
             canWriteSync(self._write_handle, 100)

can/interfaces/neousys/neousys.py

@@ -233,6 +233,7 @@ def _neousys_status_cb(self, status) -> None:
         logger.info("%s _neousys_status_cb: %d", self.init_config, status)
 
     def shutdown(self):
+        super().shutdown()
         NEOUSYS_CANLIB.CAN_Stop(self.channel)
 
     @staticmethod

can/interfaces/nican.py

@@ -375,4 +375,5 @@ def reset(self) -> None:
 
     def shutdown(self) -> None:
         """Close object."""
+        super().shutdown()
         nican.ncCloseObject(self.handle)

can/interfaces/nixnet.py

@@ -221,6 +221,7 @@ def reset(self):
 
     def shutdown(self):
         """Close object."""
+        super().shutdown()
         self.__session_send.flush()
         self.__session_receive.flush()
 

can/interfaces/robotell.py

@@ -367,6 +367,7 @@ def send(self, msg, timeout=None):
         )
 
     def shutdown(self):
+        super().shutdown()
         self.serialPortOrig.close()
 
     def fileno(self):