Fix SocketCAN periodic Tasks on Python 2 #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socket.error is a deprecated alias of OSError used on Python versions lower than 3.3. Also cherry pick over the relevant cyclic SocketCAN tests and enable Travis CI for SocketCAN tests on Python 2. Fixes hardbyte#845
Collaborator
Author
|
Not sure if you want to cut a new release. If you do, feel free to create a new branch and edit the PR to be against that branch. |
Codecov Report
@@ Coverage Diff @@
## release-3.3.3 #850 +/- ##
=================================================
+ Coverage 64.58% 66.07% +1.49%
=================================================
Files 63 63
Lines 5822 5822
=================================================
+ Hits 3760 3847 +87
+ Misses 2062 1975 -87 |
hardbyte
approved these changes
Jun 18, 2020
Owner
hardbyte
left a comment
hardbyte
left a comment
There was a problem hiding this comment.
Thanks! Yup changed the base branch and we'll make a new (hopefully last!) Python2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.error is a deprecated alias of OSError used on Python versions
lower than 3.3.
Also cherry pick over the relevant cyclic SocketCAN tests and enable
Travis CI for SocketCAN tests on Python 2.
Fixes #845