chore(validator): refine error msg of lenght validator

Author: mattwang44

data_spec_validator/spec/validators.py

@@ -370,8 +370,12 @@ def validate(value, extra, data) -> Tuple[bool, Union[Exception, str]]:
             RuntimeError('Lower boundary cannot less than 0 for length validator'),
         )
 
-        ok = lower_bound <= len(value) <= upper_bound if upper_bound else lower_bound <= len(value)
-        info = '' if ok else ValueError(f'Length of {repr(value)} must be between {lower_bound} and {upper_bound}')
+        if upper_bound:
+            ok = lower_bound <= len(value) <= upper_bound
+            info = '' if ok else ValueError(f'Length of {repr(value)} must be between {lower_bound} and {upper_bound}')
+        else:
+            ok = lower_bound <= len(value)
+            info = '' if ok else ValueError(f'Length of {repr(value)} must be greater than {lower_bound}')
         return ok, info
 
 

test/test_spec.py

@@ -246,6 +246,24 @@ class LengthSpec:
         nok_data = dict(length_field='exceed')
         assert is_something_error(ValueError, validate_data_spec, nok_data, LengthSpec)
 
+        # assert error message
+        with self.assertRaises(ValueError) as e:
+            validate_data_spec(dict(length_field='ah'), LengthSpec)
+        
+        expected_error_msg = "field: LengthSpec.length_field, reason: Length of 'ah' must be between 3 and 5"
+        self.assertEqual(str(e.exception), expected_error_msg)
+
+    def test_length__without_upper_limit(self):
+        class LengthSpec:
+            length_field = Checker([LENGTH], LENGTH=dict(min=3))
+        
+        # assert error message
+        with self.assertRaises(ValueError) as e:
+            validate_data_spec(dict(length_field='ah'), LengthSpec)
+
+        expected_error_msg = "field: LengthSpec.length_field, reason: Length of 'ah' must be greater than 3"
+        self.assertEqual(str(e.exception), expected_error_msg)
+
     def test_decimal_place(self):
         class DecimalPlaceSpec:
             decimal_place_field = Checker([DECIMAL_PLACE], DECIMAL_PLACE=4)