Skip to content

Commit a6a2175

Browse files
committed
Merge commit 'b56863dad3f81a45ae289202426d82cac159d30a' into support-bs-3
# Conflicts: # src/progressbar/bar.component.ts # src/tooltip/tooltip-container.component.ts # src/typeahead/typeahead-container.component.ts
2 parents e3dcd51 + b56863d commit a6a2175

File tree

243 files changed

+10212
-7957
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

243 files changed

+10212
-7957
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Editor configuration, see http://editorconfig.org
1+
# Editor configuration, see https://editorconfig.org
22
root = true
33

44
[*]

.eslintrc.json

Lines changed: 16 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,12 @@
11
{
22
"root": true,
3-
"ignorePatterns": [
4-
"**/*"
5-
],
6-
"plugins": [
7-
"@nx"
8-
],
3+
"ignorePatterns": ["**/*"],
4+
"plugins": ["@nx"],
95
"rules": {},
106
"overrides": [
117
{
12-
"files": [
13-
"*.ts",
14-
"*.tsx",
15-
"*.js",
16-
"*.jsx"
17-
],
8+
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
9+
"excludedFiles": ["*.spec.ts"],
1810
"rules": {
1911
"@nx/enforce-module-boundaries": [
2012
"error",
@@ -24,42 +16,33 @@
2416
"depConstraints": [
2517
{
2618
"sourceTag": "*",
27-
"onlyDependOnLibsWithTags": [
28-
"*"
29-
]
19+
"onlyDependOnLibsWithTags": ["*"]
3020
}
3121
]
3222
}
3323
]
3424
}
3525
},
3626
{
37-
"files": [
38-
"*.ts",
39-
"*.tsx"
40-
],
41-
"extends": [
42-
"plugin:@nx/typescript"
43-
],
27+
"files": ["*.ts", "*.tsx"],
28+
"extends": ["plugin:@nx/typescript"],
4429
"parserOptions": {
4530
"project": "./tsconfig.*?.json"
4631
},
4732
"rules": {
4833
"semi": "off",
49-
"@typescript-eslint/semi": [
50-
"error"
51-
]
34+
"@typescript-eslint/semi": ["error"],
35+
"@typescript-eslint/no-extra-semi": "error",
36+
"no-extra-semi": "off"
5237
}
5338
},
5439
{
55-
"files": [
56-
"*.js",
57-
"*.jsx"
58-
],
59-
"extends": [
60-
"plugin:@nx/javascript"
61-
],
62-
"rules": {}
40+
"files": ["*.js", "*.jsx"],
41+
"extends": ["plugin:@nx/javascript"],
42+
"rules": {
43+
"@typescript-eslint/no-extra-semi": "error",
44+
"no-extra-semi": "off"
45+
}
6346
}
6447
]
6548
}
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
name: on-gh-release
2+
on:
3+
release:
4+
types: [released]
5+
branches:
6+
- development
7+
8+
env:
9+
NX_BRANCH: ${{ github.event.number }}
10+
NX_RUN_GROUP: ${{ github.run_id }}
11+
NX_CLOUD_AUTH_TOKEN: ${{ secrets.NX_CLOUD_AUTH_TOKEN }}
12+
MOZ_HEADLESS: 1
13+
CONVENTIONAL_GITHUB_RELEASER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
14+
15+
jobs:
16+
# one run
17+
one_run:
18+
runs-on: ubuntu-latest
19+
steps:
20+
- name: Cancel Previous Runs
21+
uses: styfle/[email protected]
22+
with:
23+
access_token: ${{ secrets.GITHUB_TOKEN }}
24+
25+
# update npm tags
26+
npm_tag_update:
27+
runs-on: ubuntu-latest
28+
needs: one_run
29+
steps:
30+
- uses: actions/checkout@v3
31+
- uses: actions/cache@v3
32+
- name: get-npm-version
33+
id: package-version
34+
uses: martinbeentjes/[email protected]
35+
- run: |
36+
npm config set registry https://registry.npmjs.org/
37+
npm config set //registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}
38+
npm dist-tag add ngx-bootstrap@${{ steps.package-version.outputs.current-version}} latest

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
# dependencies
1010
/node_modules
11+
src/root/node_modules
1112

1213
# IDEs and editors
1314
/.idea

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11

22

3+
## [18.0.0](https://github.com/valor-software/ngx-bootstrap/compare/v11.0.2...v18.0.0) (2024-07-1)
4+
* Migration to Angular 18
5+
* Synced major version of the lib with major version of Angular
6+
7+
38
## [11.0.2](https://github.com/valor-software/ngx-bootstrap/compare/v11.0.1...v11.0.2) (2023-07-13)
49

510

@@ -2513,4 +2518,4 @@
25132518

25142519
* **build:** works good with [email protected] ([31c513b](https://github.com/valor-software/ngx-bootstrap/commit/31c513b4f4f084ae0eabe82b2d8bec028bb48572))
25152520
* **ng 2.0.37:** ts errors fixed ([1e19f55](https://github.com/valor-software/ngx-bootstrap/commit/1e19f555da161f1f572ed6747eb6d72796060ed8))
2516-
* **typeahead:** ts style fixes ([3eab1e4](https://github.com/valor-software/ngx-bootstrap/commit/3eab1e428ebe3ce2ddf1013d48693bc38e23c150))
2521+
* **typeahead:** ts style fixes ([3eab1e4](https://github.com/valor-software/ngx-bootstrap/commit/3eab1e428ebe3ce2ddf1013d48693bc38e23c150))

README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,19 @@ npm install ngx-bootstrap --save
101101

102102
Add wanted package to NgModule imports:
103103

104-
```
104+
```ts
105105
import { TooltipModule } from 'ngx-bootstrap/tooltip';
106106

107107
@NgModule({
108108
...
109-
imports: [TooltipModule.forRoot(),...]
109+
imports: [TooltipModule,...]
110110
...
111111
})
112112
```
113113

114114
Add component to your page:
115115

116-
```
116+
```html
117117
<button type="button" class="btn btn-primary"
118118
tooltip="Vivamus sagittis lacus vel augue laoreet rutrum faucibus.">
119119
Simple demo
@@ -126,14 +126,14 @@ This can be done with the css file directly in the index.html, or alternatively
126126

127127
- `Bootstrap 5`
128128

129-
```
129+
```html
130130
<!--- index.html -->
131131
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-rbsA2VBKQhggwzxH7pPCaAqO46MgnOM80zW1RWuH61DGLwZJEdK2Kadq2F9CUG65" crossorigin="anonymous">
132132
```
133133

134134
- `Bootstrap 4`
135135

136-
```
136+
```html
137137
<!--- index.html -->
138138
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" crossorigin="anonymous" integrity="sha384-TX8t27EcRE3e/ihU7zmQxVncDAy5uIKz4rEkgIXeMed4M0jlfIDPvg6uqKI2xXr2">
139139
```
@@ -154,7 +154,7 @@ have a customized version of bootstrap. The consequence is that the process of d
154154
be failed, which can break the UI. In that case, we can still set the bootstrap version manually in the bootstrapping
155155
component (i.e. `AppComponent`):
156156

157-
```
157+
```ts
158158
import { setTheme } from 'ngx-bootstrap/utils';
159159

160160
@Component({...})
@@ -184,7 +184,8 @@ The only two dependencies are [Angular](https://angular.io) and [Bootstrap](http
184184
Here is the version compatibility list:
185185

186186
| ngx-bootstrap | Angular | Bootstrap CSS |
187-
| ------------- | --------------- | ----------------------- |
187+
|---------------| --------------- | ----------------------- |
188+
| 18.x.x | 18.x.x | 5.x.x or 4.x.x |
188189
| 12.x.x | 17.x.x | 5.x.x or 4.x.x |
189190
| 11.x.x | 16.x.x | 5.x.x or 4.x.x |
190191
| 10.x.x | 15.x.x | 5.x.x or 4.x.x |

apps/ngx-bootstrap-docs-e2e/project.json

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
"$schema": "../../node_modules/nx/schemas/project-schema.json",
44
"sourceRoot": "apps/ngx-bootstrap-docs-e2e/src",
55
"projectType": "application",
6+
"tags": [],
7+
"implicitDependencies": ["ngx-bootstrap-docs"],
68
"targets": {
79
"e2e": {
810
"executor": "@nxkit/playwright:test",
@@ -44,12 +46,7 @@
4446
},
4547
"lint": {
4648
"executor": "@nx/eslint:lint",
47-
"outputs": ["{options.outputPath}"],
48-
"options": {
49-
"lintFilePatterns": ["apps/ngx-bootstrap-docs-e2e/**/*.{js,ts}"]
50-
}
49+
"outputs": ["{options.outputPath}"]
5150
}
52-
},
53-
"tags": [],
54-
"implicitDependencies": ["ngx-bootstrap-docs"]
51+
}
5552
}

apps/ngx-bootstrap-docs/.eslintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"../../.eslintrc.json"
44
],
55
"ignorePatterns": [
6-
"!**/*"
6+
"!**/*",
7+
"**/assets/**"
78
],
89
"overrides": [
910
{

apps/ngx-bootstrap-docs/project.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"projectType": "application",
55
"sourceRoot": "apps/ngx-bootstrap-docs/src",
66
"prefix": "ngx-bootstrap-base",
7+
"implicitDependencies": ["ngx-bootstrap"],
78
"targets": {
89
"build": {
910
"executor": "@angular-devkit/build-angular:browser",
@@ -87,11 +88,7 @@
8788
}
8889
},
8990
"lint": {
90-
"executor": "@nx/eslint:lint",
91-
"options": {
92-
"lintFilePatterns": ["apps/ngx-bootstrap-docs/src/**/*.ts", "apps/ngx-bootstrap-docs/src/**/*.html"]
93-
}
91+
"executor": "@nx/eslint:lint"
9492
}
95-
},
96-
"implicitDependencies": ["ngx-bootstrap"]
93+
}
9794
}
Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { HttpClientModule } from '@angular/common/http';
1+
import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
22
import { NgModule } from '@angular/core';
33
import { RouterModule } from '@angular/router';
4-
import { BsDropdownModule } from 'ngx-bootstrap/dropdown';
54
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
65

76
import { environment } from '../environments/environment';
@@ -10,22 +9,17 @@ import { AppComponent } from './app.component';
109
import { DOCS_TOKENS, DocsModule, NgApiDoc, SIDEBAR_ROUTES, SidebarRoutesStructure } from '@ngx-bootstrap-doc/docs';
1110
import { routes } from './app.routing';
1211

13-
@NgModule({
14-
declarations: [
15-
AppComponent
16-
],
17-
imports: [
18-
BrowserAnimationsModule,
19-
DocsModule,
20-
HttpClientModule,
21-
RouterModule.forRoot(routes, { useHash: environment.useHash }),
22-
BsDropdownModule.forRoot()
23-
],
24-
providers: [
25-
{ provide: NgApiDoc, useValue: ngdoc },
26-
{ provide: DOCS_TOKENS, useValue: routes },
27-
{ provide: SIDEBAR_ROUTES, useValue: SidebarRoutesStructure }],
28-
bootstrap: [AppComponent]
29-
})
12+
@NgModule({ declarations: [
13+
AppComponent
14+
],
15+
bootstrap: [AppComponent], imports: [BrowserAnimationsModule,
16+
DocsModule,
17+
RouterModule.forRoot(routes, { useHash: environment.useHash })
18+
], providers: [
19+
{ provide: NgApiDoc, useValue: ngdoc },
20+
{ provide: DOCS_TOKENS, useValue: routes },
21+
{ provide: SIDEBAR_ROUTES, useValue: SidebarRoutesStructure },
22+
provideHttpClient(withInterceptorsFromDi())
23+
] })
3024
export class AppModule {
3125
}

0 commit comments

Comments
 (0)