Pass FrameManager to NetworkManager constructor (#1291)

Author: kblok

lib/PuppeteerSharp/FrameManager.cs

@@ -29,8 +29,7 @@ private FrameManager(CDPSession client, Page page, bool ignoreHTTPSErrors, Timeo
             _frames = new ConcurrentDictionary<string, Frame>();
             _contextIdToContext = new Dictionary<int, ExecutionContext>();
             _logger = Client.Connection.LoggerFactory.CreateLogger<FrameManager>();
-            NetworkManager = new NetworkManager(client, ignoreHTTPSErrors);
-            NetworkManager.FrameManager = this;
+            NetworkManager = new NetworkManager(client, ignoreHTTPSErrors, this);
             TimeoutSettings = timeoutSettings;
             _asyncFrames = new AsyncDictionaryHelper<string, Frame>(_frames, "Frame {0} not found");
 

lib/PuppeteerSharp/NetworkManager.cs

@@ -29,9 +29,9 @@ internal class NetworkManager
         private bool _userCacheDisabled;
         #endregion
 
-        internal NetworkManager(CDPSession client, bool ignoreHTTPSErrors)
+        internal NetworkManager(CDPSession client, bool ignoreHTTPSErrors, FrameManager frameManager)
         {
-            FrameManager = null;
+            FrameManager = frameManager;
             _client = client;
             _ignoreHTTPSErrors = ignoreHTTPSErrors;
             _client.MessageReceived += Client_MessageReceived;
@@ -306,7 +306,7 @@ private async Task OnRequestAsync(RequestWillBeSentPayload e, string interceptio
             if (!_requestIdToRequest.TryGetValue(e.RequestId, out var currentRequest) ||
               currentRequest.Frame == null)
             {
-                var frame = await FrameManager?.GetFrameAsync(e.FrameId);
+                var frame = await FrameManager.GetFrameAsync(e.FrameId);
 
                 request = new Request(
                     _client,