Fix redirect issues (#72)

Author: kblok

lib/PuppeteerSharp.Tests/Puppeteer/PuppeteerLaunchTests.cs

@@ -24,5 +24,19 @@ public async Task ShouldSupportIgnoreHTTPSErrorsOption()
 
             await browser.CloseAsync();
         }
+
+        [Fact]
+        public async Task ShouldWorkInRealLife()
+        {
+            var options = TestConstants.DefaultBrowserOptions();
+
+            var browser = await PuppeteerSharp.Puppeteer.LaunchAsync(options, TestConstants.ChromiumRevision);
+            var page = await browser.NewPageAsync();
+
+            var response = await page.GoToAsync("https://www.google.com");
+            Assert.Equal(response.Status.ToString(), "OK");
+
+            await browser.CloseAsync();
+        }
     }
 }

lib/PuppeteerSharp/NetworkManager.cs

@@ -289,8 +289,12 @@ private void HandleRequestRedirect(Request request, HttpStatusCode redirectStatu
             var response = new Response(_client, request, redirectStatus, redirectHeaders);
             request.Response = response;
             _requestIdToRequest.Remove(request.RequestId);
-            _interceptionIdToRequest.Remove(request.InterceptionId);
-            _attemptedAuthentications.Remove(request.InterceptionId);
+
+            if (request.InterceptionId != null)
+            {
+                _interceptionIdToRequest.Remove(request.InterceptionId);
+                _attemptedAuthentications.Remove(request.InterceptionId);
+            }
 
             ResponseCreated(this, new ResponseCreatedArgs()
             {
@@ -335,14 +339,14 @@ private void OnRequestWillBeSent(MessageEventArgs e)
                 }
             }
 
-            if (e.MessageData.redirectResponse != null && _requestIdToRequest.ContainsKey(e.MessageData.requestId))
+            if (e.MessageData.redirectResponse != null && _requestIdToRequest.ContainsKey(e.MessageData.requestId.ToString()))
             {
-                var request = _requestIdToRequest[e.MessageData.requestId];
+                var request = _requestIdToRequest[e.MessageData.requestId.ToString()];
                 // If we connect late to the target, we could have missed the requestWillBeSent event.
                 HandleRequestRedirect(
                     request,
-                    e.MessageData.redirectResponse.status,
-                    e.MessageData.redirectResponse.headers);
+                    (HttpStatusCode)e.MessageData.redirectResponse.status,
+                    e.MessageData.redirectResponse.headers.ToObject<Dictionary<string, object>>());
             }
 
             HandleRequestStart(

lib/PuppeteerSharp/Page.cs

@@ -639,7 +639,7 @@ private void OnTargetCrashed()
 
         private void EmitMetrics(MessageEventArgs e)
         {
-            throw new NotImplementedException();
+
         }
 
         private async Task OnCertificateError(MessageEventArgs e)

lib/PuppeteerSharp/PuppeteerSharp.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <PackOnBuild>true</PackOnBuild>
-    <PackageVersion>0.1.0</PackageVersion>
+    <PackageVersion>0.1.1</PackageVersion>
     <Authors>Darío Kondratiuk</Authors>
     <Owners>Darío Kondratiuk</Owners>
     <PackageProjectUrl>https://github.com/kblok/puppeteer-sharp</PackageProjectUrl>