Skip to content

Commit 0b77f8c

Browse files
committed
Network improvements
1 parent 8128352 commit 0b77f8c

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

lib/PuppeteerSharp/NetworkManager.cs

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ private void OnLoadingFinished(MessageEventArgs e)
152152
{
153153
// For certain requestIds we never receive requestWillBeSent event.
154154
// @see https://crbug.com/750469
155-
if (_requestIdToRequest.ContainsKey(e.MessageData.requestId))
155+
if (_requestIdToRequest.ContainsKey(e.MessageData.requestId.ToString()))
156156
{
157-
var request = _requestIdToRequest[e.MessageData.requestId];
157+
var request = _requestIdToRequest[e.MessageData.requestId.ToString()];
158158

159159
request.CompleteTaskWrapper.SetResult(true);
160160
_requestIdToRequest.Remove(request.requestId);
@@ -171,10 +171,15 @@ private void OnLoadingFinished(MessageEventArgs e)
171171
private void OnResponseReceived(MessageEventArgs e)
172172
{
173173
// FileUpload sends a response without a matching request.
174-
if (_requestIdToRequest.ContainsKey(e.MessageData.requestId))
174+
if (_requestIdToRequest.ContainsKey(e.MessageData.requestId.ToString()))
175175
{
176-
var request = _requestIdToRequest[e.MessageData.requestId];
177-
var response = new Response(_client, request, e.MessageData.response.status, e.MessageData.response.headers);
176+
var request = _requestIdToRequest[e.MessageData.requestId.ToString()];
177+
var response = new Response(
178+
_client,
179+
request,
180+
(HttpStatusCode)e.MessageData.response.status,
181+
(Dictionary<string, object>)e.MessageData.response.headers);
182+
178183
request.Response = response;
179184

180185
ResponseReceivedFinished(this, new ResponseReceivedArgs()
@@ -189,7 +194,7 @@ private async Task OnRequestInterceptedAsync(MessageEventArgs e)
189194
if (e.MessageData.authChallenge)
190195
{
191196
var response = "Default";
192-
if (_attemptedAuthentications.Contains(e.MessageData.interceptionId))
197+
if (_attemptedAuthentications.Contains(e.MessageData.interceptionId.ToString()))
193198
{
194199
response = "CancelAuth";
195200
}

0 commit comments

Comments
 (0)