Introduce Target Managers (#2051)

* Some progress

* Some more progress

* Some passing tests

* code factor

* Some improvements

* Fix IsInitialized

* more fixes

* some updates

* Fix some tests

* Fix accessibility tests

* Update chromium version

* code cleanup

* Implement firefox target manager

* Add docs

Author: kblok

lib/PuppeteerSharp.TestServer/wwwroot/frames/frame.html

@@ -1,3 +1,8 @@
 <link rel='stylesheet' href='./style.css'>
 <script src='./script.js' type='text/javascript'></script>
+<style>
+    div {
+        line-height: 18px;
+    }
+</style>
 <div>Hi, I'm frame</div>

lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs

@@ -252,7 +252,7 @@ await Page.SetContentAsync(@"
                         new SerializedAXNode
                         {
                             Role = "StaticText",
-                            Name = "Edit this image:"
+                            Name = "Edit this image: "
                         },
                         new SerializedAXNode
                         {
@@ -284,13 +284,8 @@ await Page.SetContentAsync(@"
                         new SerializedAXNode
                         {
                             Role = "StaticText",
-                            Name = "Edit this image:"
+                            Name = "Edit this image: "
                         },
-                        new SerializedAXNode
-                        {
-                            Role = "img",
-                            Name = "my fake image"
-                        }
                     }
                 },
                 (await Page.Accessibility.SnapshotAsync()).Children[0]);

lib/PuppeteerSharp.Tests/Issues/Issue0343.cs

@@ -13,7 +13,7 @@ public Issue0343(ITestOutputHelper output) : base(output)
         {
         }
 
-        [SkipBrowserFact(skipFirefox: true)]
+        [Fact(Skip = "It seems something's changed in chromium and this is no longer valid")]
         public async Task ShouldSupportLongExpiresValueInCookies()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);

lib/PuppeteerSharp.Tests/TargetTests/TargetTests.cs

@@ -140,12 +140,11 @@ public async Task ShouldCreateAWorkerFromAServiceWorker()
         public async Task ShouldCreateAWorkerFromASharedWorker()
         {
             await Page.GoToAsync(TestConstants.EmptyPage);
-            var targetTask = Context.WaitForTargetAsync(t => t.Type == TargetType.SharedWorker);
             await Page.EvaluateFunctionAsync(@"() =>
             {
                 new SharedWorker('data:text/javascript,console.log(""hi"")');
             }");
-            var target = await targetTask;
+            var target = await Context.WaitForTargetAsync(t => t.Type == TargetType.SharedWorker);
             var worker = await target.WorkerAsync();
             Assert.Equal("[object SharedWorkerGlobalScope]", await worker.EvaluateFunctionAsync("() => self.toString()"));
         }