Skip to content

Commit 15a218d

Browse files
Reduce memory allocations in LowSurrogateConverter for .NET 8 (#2901)
* Remove .ToArrat() for .NET 8 * Fix names * Bump SixLabors.imageSharp to 3.1.7
1 parent a87b860 commit 15a218d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</PackageReference>
1919
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
2020
<PackageReference Include="System.Net.Http" Version="4.3.4" />
21-
<PackageReference Include="SixLabors.ImageSharp" Version="3.1.5" />
21+
<PackageReference Include="SixLabors.ImageSharp" Version="3.1.7" />
2222
<PackageReference Include="Microsoft.AspNetCore.Connections.Abstractions" Version="2.2.0" />
2323
</ItemGroup>
2424
<Import Project="../Common/CommonProps.props" />

lib/PuppeteerSharp/Helpers/Json/LowSurrogateConverter.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ public override string Read(ref Utf8JsonReader reader, Type typeToConvert, JsonS
1515
return null;
1616
}
1717

18-
var span = reader.HasValueSequence ? reader.ValueSequence.ToArray() : reader.ValueSpan.ToArray();
18+
var span = reader.HasValueSequence
19+
? reader.ValueSequence.ToArray()
20+
#if NET8_0_OR_GREATER
21+
: reader.ValueSpan;
22+
#else
23+
: reader.ValueSpan.ToArray();
24+
#endif
1925
var value = Encoding.UTF8.GetString(span);
2026

2127
try

0 commit comments

Comments
 (0)