Disable component extensions (#1241)

* Disable component extensions

* Fix test

Author: kblok

lib/PuppeteerSharp.Tests/Assets/simple-extension/content-script.js

@@ -0,0 +1,3 @@
+console.log('hey from the content-script');
+self.thisIsTheContentScript = true;
+

lib/PuppeteerSharp.Tests/Assets/simple-extension/index.js

@@ -1 +1,2 @@
-// Mock script for background extension
+// Mock script for background extension
+window.MAGIC = 42;

lib/PuppeteerSharp.Tests/Assets/simple-extension/manifest.json

@@ -1,12 +1,14 @@
 {
-    "name": "Simple extension",
-    "version": "0.1",
-    "app": {
-      "background": {
-        "scripts": ["index.js"]
-      }
-    },
-    "permissions": ["background"],
-    
-    "manifest_version": 2
-  }
+  "name": "Simple extension",
+  "version": "0.1",
+  "background": {
+    "scripts": ["index.js"]
+  },
+  "content_scripts": [{
+    "matches": ["<all_urls>"],
+    "css": [],
+    "js": ["content-script.js"]
+  }],
+  "permissions": ["background", "activeTab"],
+  "manifest_version": 2
+}

lib/PuppeteerSharp.Tests/PuppeteerTests/HeadfulTests.cs

@@ -37,6 +37,7 @@ public async Task TargetPageShouldReturnABackgroundPage()
                 var backgroundPageTarget = await WaitForBackgroundPageTargetAsync(browserWithExtension);
                 var page = await backgroundPageTarget.PageAsync();
                 Assert.Equal(6, await page.EvaluateFunctionAsync<int>("() => 2 * 3"));
+                Assert.Equal(42, await page.EvaluateFunctionAsync<int>("() => window.MAGIC"));
             }
         }
 

lib/PuppeteerSharp/ChromiumProcess.cs

@@ -27,6 +27,7 @@ public class ChromiumProcess : IDisposable
             "--disable-backgrounding-occluded-windows",
             "--disable-breakpad",
             "--disable-client-side-phishing-detection",
+            "--disable-component-extensions-with-background-pages",
             "--disable-default-apps",
             "--disable-dev-shm-usage",
             "--disable-extensions",

lib/PuppeteerSharp/Helpers/RemoteObjectHelper.cs

@@ -23,7 +23,7 @@ internal static object ValueFromRemoteObject<T>(RemoteObject remoteObject)
 
             if (value == null)
             {
-                return null;
+                return default(T);
             }
 
             return typeof(T) == typeof(JToken) ? value : ValueFromType<T>(value, remoteObject.Type);