Page.goto with 204 (#450)

Author: Meir017

lib/PuppeteerSharp.TestServer/wwwroot/historyapi.html

@@ -0,0 +1,5 @@
+<script>
+window.addEventListener('DOMContentLoaded', () => {
+  history.pushState({}, '', '#1');
+});
+</script>

lib/PuppeteerSharp.Tests/PageTests/GotoTests.cs

@@ -34,6 +34,37 @@ public async Task ShouldNavigateToEmptyPageWithDOMContentLoaded()
             Assert.Null(response.SecurityDetails);
         }
 
+        [Fact]
+        public async Task ShouldFailWhenServerReturns204()
+        {
+            Server.SetRoute("/empty.html", context =>
+            {
+                context.Response.StatusCode = 204;
+                return Task.CompletedTask;
+            });
+            var exception = await Assert.ThrowsAnyAsync<PuppeteerException>(
+                () => Page.GoToAsync(TestConstants.EmptyPage));
+            Assert.Contains("net::ERR_ABORTED", exception.Message);
+        }
+
+        [Fact]
+        public async Task ShouldReturnResponseWhenPageChangesItsURLAfterLoad()
+        {
+            var response = await Page.GoToAsync(TestConstants.ServerUrl + "/historyapi.html");
+            Assert.Equal(HttpStatusCode.OK, response.Status);
+        }
+
+        [Fact]
+        public async Task ShouldWorkWithSubframesReturn204()
+        {
+            Server.SetRoute("/frames/frame.html", context =>
+            {
+                context.Response.StatusCode = 204;
+                return Task.CompletedTask;
+            });
+            await Page.GoToAsync(TestConstants.ServerUrl + "/frames/one-frame.html");
+        }
+
         [Theory]
         [InlineData(WaitUntilNavigation.Networkidle0)]
         [InlineData(WaitUntilNavigation.Networkidle2)]

lib/PuppeteerSharp/Frame.cs

@@ -47,6 +47,7 @@ public class Frame
         internal string Id { get; set; }
         internal string LoaderId { get; set; }
         internal List<string> LifecycleEvents { get; }
+        internal string NavigationURL { get; private set; }
 
         internal Frame(CDPSession client, Page page, Frame parentFrame, string frameId)
         {
@@ -580,6 +581,7 @@ internal void OnLifecycleEvent(string loaderId, string name)
         internal void Navigated(FramePayload framePayload)
         {
             Name = framePayload.Name ?? string.Empty;
+            NavigationURL = framePayload.Url;
             Url = framePayload.Url;
         }
 

lib/PuppeteerSharp/Page.cs

@@ -708,7 +708,7 @@ await Task.WhenAll(
                 throw new NavigationException(exception.InnerException.Message, exception.InnerException);
             }
 
-            requests.TryGetValue(MainFrame.Url, out var request);
+            requests.TryGetValue(MainFrame.NavigationURL, out var request);
 
             return request?.Response;
         }